From: Eric Engestrom <eric.engestrom@imgtec.com>
To: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: fix trivial typo in warning message
Date: Fri, 8 Jan 2016 12:10:50 +0000 [thread overview]
Message-ID: <568FA74A.1010805@imgtec.com> (raw)
In-Reply-To: <568F82CF.1040504@amd.com>
Yes, a quick grep shows the same typo in several places:
> $ grep -Rwn 'to small' drivers/gpu/
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:544: DRM_ERROR("BO to small for addr 0x%010Lx %d %d\n",
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:648: DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:656: DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
> drivers/gpu/drm/radeon/radeon_device.c:1153: dev_warn(rdev->dev, "VM size (%d) to small, min is 1GB\n",
> drivers/gpu/drm/radeon/radeon_vce.c:501: DRM_ERROR("buffer to small (%d / %d)!\n",
> drivers/gpu/drm/radeon/radeon_uvd.c:563: DRM_ERROR("buffer (%d) to small (%d / %d)!\n", cmd,
BTW there's also a 'to large' one:
> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:342: /* clamp timeout if it's to large */
On 08/01/16 09:35, Christian König wrote:
> Am 08.01.2016 um 01:22 schrieb Alexandre Demers:
>> Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>.
>
> We probably need to fix this in amdgpu as well.
>
> Thanks for the help,
> Christian.
>
>> ---
>> drivers/gpu/drm/radeon/radeon_device.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
>> index c566993..4197ca1 100644
>> --- a/drivers/gpu/drm/radeon/radeon_device.c
>> +++ b/drivers/gpu/drm/radeon/radeon_device.c
>> @@ -1150,7 +1150,7 @@ static void radeon_check_arguments(struct radeon_device *rdev)
>> }
>>
>> if (radeon_vm_size < 1) {
>> - dev_warn(rdev->dev, "VM size (%d) to small, min is 1GB\n",
>> + dev_warn(rdev->dev, "VM size (%d) too small, min is 1GB\n",
>> radeon_vm_size);
>> radeon_vm_size = 4;
>> }
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-08 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 0:22 [PATCH] drm/radeon: fix trivial typo in warning message Alexandre Demers
2016-01-08 9:35 ` Christian König
2016-01-08 12:10 ` Eric Engestrom [this message]
2016-01-08 17:36 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568FA74A.1010805@imgtec.com \
--to=eric.engestrom@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.