All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Hunt <harvey.hunt@imgtec.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
	Brian Norris <computersforpeace@gmail.com>
Cc: <linux-mtd@lists.infradead.org>, Alex Smith <alex@alex-smith.me.uk>
Subject: Re: [PATCH] mtd: jz4780_nand: replace if/else blocks with switch/case
Date: Fri, 8 Jan 2016 12:30:32 +0000	[thread overview]
Message-ID: <568FABE8.8070604@imgtec.com> (raw)
In-Reply-To: <20160108132836.79fb4a81@bbrezillon>

Hi,

On 08/01/16 12:28, Boris Brezillon wrote:
> On Thu,  7 Jan 2016 09:53:08 -0800
> Brian Norris <computersforpeace@gmail.com> wrote:
>
>> Using switch/case helps make this logic more clear and more robust. With
>> this structure:
>>
>>   * it's clear that this driver only support ECC_{HW,SOFT,SOFT_BCH}; and
>>
>>   * we can sanely handle new ECC unsupported modes (right now, this code
>>     makes incorrect assumptions about the possible values in the
>>     nand_ecc_modes_t enum; e.g., what happens with NAND_ECC_HW_OOB_FIRST?)
>>
>> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>> Cc: Alex Smith <alex@alex-smith.me.uk>
>> Cc: Harvey Hunt <harvey.hunt@imgtec.com>
>
> LGTM
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>

If it helps, I can add my Tested-By later today?

Harvey

  reply	other threads:[~2016-01-08 12:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 17:53 [PATCH] mtd: jz4780_nand: replace if/else blocks with switch/case Brian Norris
2016-01-08 12:28 ` Boris Brezillon
2016-01-08 12:30   ` Harvey Hunt [this message]
2016-01-08 12:41     ` Boris Brezillon
2016-01-08 16:26 ` Harvey Hunt
2016-01-08 17:49   ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568FABE8.8070604@imgtec.com \
    --to=harvey.hunt@imgtec.com \
    --cc=alex@alex-smith.me.uk \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.