From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [rtc-linux] [PATCH 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 Date: Fri, 8 Jan 2016 18:49:19 +0530 Message-ID: <568FB757.9080303@nvidia.com> References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-3-git-send-email-ldewangan@nvidia.com> <568F7E7B.1010501@nvidia.com> <568FB62C.9020109@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <568FB62C.9020109@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski , rtc-linux@googlegroups.com Cc: k.kozlowski.k@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, swarren@nvidia.com, treding@nvidia.com, Chaitanya Bandi , Mallikarjun Kasoju List-Id: linux-gpio@vger.kernel.org On Friday 08 January 2016 06:44 PM, Krzysztof Kozlowski wrote: > > To avoid compilation warning, I need to use inline here. > Because this shouldn't be defined in header at the first place. Instead > define it in main MFD driver with EXPORT_SYMBOL() and put in headers > just declaration. > what about __maybe_unused instead on inline and keep in header. Anyhow, I do not have any personal choice here. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com. [216.228.121.64]) by gmr-mx.google.com with ESMTPS id a76si314290pfj.2.2016.01.08.05.29.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jan 2016 05:29:26 -0800 (PST) Message-ID: <568FB757.9080303@nvidia.com> Date: Fri, 8 Jan 2016 18:49:19 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Krzysztof Kozlowski , CC: , , , , , , , , , , , , , , , , , , Chaitanya Bandi , Mallikarjun Kasoju Subject: Re: [rtc-linux] [PATCH 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-3-git-send-email-ldewangan@nvidia.com> <568F7E7B.1010501@nvidia.com> <568FB62C.9020109@samsung.com> In-Reply-To: <568FB62C.9020109@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Friday 08 January 2016 06:44 PM, Krzysztof Kozlowski wrote: > > To avoid compilation warning, I need to use inline here. > Because this shouldn't be defined in header at the first place. Instead > define it in main MFD driver with EXPORT_SYMBOL() and put in headers > just declaration. > what about __maybe_unused instead on inline and keep in header. Anyhow, I do not have any personal choice here. -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754205AbcAHN32 (ORCPT ); Fri, 8 Jan 2016 08:29:28 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:12784 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750875AbcAHN30 (ORCPT ); Fri, 8 Jan 2016 08:29:26 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 08 Jan 2016 05:25:07 -0800 Message-ID: <568FB757.9080303@nvidia.com> Date: Fri, 8 Jan 2016 18:49:19 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , CC: , , , , , , , , , , , , , , , , , , Chaitanya Bandi , Mallikarjun Kasoju Subject: Re: [rtc-linux] [PATCH 2/6] mfd: max77620: add core driver for MAX77620/MAX20024 References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-3-git-send-email-ldewangan@nvidia.com> <568F7E7B.1010501@nvidia.com> <568FB62C.9020109@samsung.com> In-Reply-To: <568FB62C.9020109@samsung.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 08 January 2016 06:44 PM, Krzysztof Kozlowski wrote: > > To avoid compilation warning, I need to use inline here. > Because this shouldn't be defined in header at the first place. Instead > define it in main MFD driver with EXPORT_SYMBOL() and put in headers > just declaration. > what about __maybe_unused instead on inline and keep in header. Anyhow, I do not have any personal choice here.