From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joao Pinto Subject: Re: [PATCH] add driver for DesignWare UFS Host Controller Date: Fri, 8 Jan 2016 15:51:22 +0000 Message-ID: <568FDAFA.9020507@synopsys.com> References: <20160107094437.GA11038@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from smtprelay.synopsys.com ([198.182.60.111]:42644 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbcAHPv2 (ORCPT ); Fri, 8 Jan 2016 10:51:28 -0500 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Akinobu Mita , Christoph Hellwig Cc: Joao Pinto , Yaniv Gardi , Gilad Broner , Subhash Jadavani , "linux-scsi@vger.kernel.org" , CARLOS.PALMINHA@synopsys.com Hi, On 1/8/2016 2:20 PM, Akinobu Mita wrote: > 2016-01-07 18:44 GMT+09:00 Christoph Hellwig : >>> This driver patch includes a core driver and glue drivers for pci and platform >>> for the DesignWare UFS Host IP. >> >> Why doesn't this use the existing ufs core? The architecture looks >> completely backwards to me. > > I agree. The existing ufs driver can have variant specific operations > (hba->vops) and also can define quirks. So if DesignWare UFS host > controller requires vendor specific register settings or DME operations > in initialization, or needs special workarounds for the specific versions, > it can use those mechanisms and shares common parts between other host > controllers. > I agree with you. We're already engaging internally a patch rework and so there will be a new patch soon based on your comments. Thank you for your comments. Joao