From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHdXL-0003kM-Lr for qemu-devel@nongnu.org; Fri, 08 Jan 2016 15:21:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHdXK-0001Z7-Ig for qemu-devel@nongnu.org; Fri, 08 Jan 2016 15:21:27 -0500 Received: from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]:35000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHdXK-0001Z2-Cx for qemu-devel@nongnu.org; Fri, 08 Jan 2016 15:21:26 -0500 Received: by mail-oi0-x231.google.com with SMTP id p187so734055oia.2 for ; Fri, 08 Jan 2016 12:21:26 -0800 (PST) References: <1452015002-28493-4-git-send-email-clg@fr.ibm.com> From: Corey Minyard Message-ID: <56901A44.1090008@mvista.com> Date: Fri, 8 Jan 2016 14:21:24 -0600 MIME-Version: 1.0 In-Reply-To: <1452015002-28493-4-git-send-email-clg@fr.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 3/8] ipmi: add GET_SYS_RESTART_CAUSE chassis command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" Acked-by: Corey Minyard On 01/05/2016 11:29 AM, Cédric Le Goater wrote: > This is a simulator. Just return an unknown cause (0). > > Signed-off-by: Cédric Le Goater > --- > hw/ipmi/ipmi_bmc_sim.c | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c > index 061db8437479..5db94491b130 100644 > --- a/hw/ipmi/ipmi_bmc_sim.c > +++ b/hw/ipmi/ipmi_bmc_sim.c > @@ -30,11 +30,12 @@ > #include "qemu/error-report.h" > > #define IPMI_NETFN_CHASSIS 0x00 > -#define IPMI_NETFN_CHASSIS_MAXCMD 0x03 > +#define IPMI_NETFN_CHASSIS_MAXCMD 0x0a > > #define IPMI_CMD_GET_CHASSIS_CAPABILITIES 0x00 > #define IPMI_CMD_GET_CHASSIS_STATUS 0x01 > #define IPMI_CMD_CHASSIS_CONTROL 0x02 > +#define IPMI_CMD_GET_SYS_RESTART_CAUSE 0x09 > > #define IPMI_NETFN_SENSOR_EVENT 0x04 > #define IPMI_NETFN_SENSOR_EVENT_MAXCMD 0x30 > @@ -201,6 +202,8 @@ struct IPMIBmcSim { > uint8_t mfg_id[3]; > uint8_t product_id[2]; > > + uint8_t restart_cause; > + > IPMISel sel; > IPMISdr sdr; > IPMISensor sensors[MAX_SENSORS]; > @@ -754,6 +757,17 @@ static void chassis_control(IPMIBmcSim *ibs, > return; > } > > +static void chassis_get_sys_restart_cause(IPMIBmcSim *ibs, > + uint8_t *cmd, unsigned int cmd_len, > + uint8_t *rsp, unsigned int *rsp_len, > + unsigned int max_rsp_len) > +{ > + IPMI_ADD_RSP_DATA(ibs->restart_cause & 0xf); /* Restart Cause */ > + IPMI_ADD_RSP_DATA(0); /* Channel 0 */ > + out: > + return; > +} > + > static void get_device_id(IPMIBmcSim *ibs, > uint8_t *cmd, unsigned int cmd_len, > uint8_t *rsp, unsigned int *rsp_len, > @@ -1624,7 +1638,8 @@ static void get_sensor_type(IPMIBmcSim *ibs, > static const IPMICmdHandler chassis_cmds[IPMI_NETFN_CHASSIS_MAXCMD] = { > [IPMI_CMD_GET_CHASSIS_CAPABILITIES] = chassis_capabilities, > [IPMI_CMD_GET_CHASSIS_STATUS] = chassis_status, > - [IPMI_CMD_CHASSIS_CONTROL] = chassis_control > + [IPMI_CMD_CHASSIS_CONTROL] = chassis_control, > + [IPMI_CMD_GET_SYS_RESTART_CAUSE] = chassis_get_sys_restart_cause > }; > static const IPMINetfn chassis_netfn = { > .cmd_nums = IPMI_NETFN_CHASSIS_MAXCMD, > @@ -1746,6 +1761,7 @@ static void ipmi_sim_init(Object *obj) > ibs->bmc_global_enables = (1 << IPMI_BMC_EVENT_LOG_BIT); > ibs->device_id = 0x20; > ibs->ipmi_version = 0x02; /* IPMI 2.0 */ > + ibs->restart_cause = 0; > for (i = 0; i < 4; i++) { > ibs->sel.last_addition[i] = 0xff; > ibs->sel.last_clear[i] = 0xff;