All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tariq Saeed <tariq.x.saeed@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] revert to using ocfs2_acl_chmod to avoid inode cluster lock hang
Date: Fri, 08 Jan 2016 14:44:29 -0800	[thread overview]
Message-ID: <56903BCD.6050806@oracle.com> (raw)
In-Reply-To: <20160108014556.GD819@wotan.suse.de>


On 01/07/2016 05:45 PM, Mark Fasheh wrote:
>> 2. ocfs2_reflink ->  ocfs2_init_security_and_acl -> ocfs2_iop_set_acl
> Could you elaborate for me on the problem you found there?
The problem here is dropping dir lock in posix_acl_create after getting
default_acl and acl. These two can be changed by another node by
the time we get around to using  them in ocfs2_init_security_and_acl.

The old code in uek3 is mindful of this. In that code, 
ocfs2_init_security_and_acl
gets the dir lock and keeps it until the acls of new node are set.
Thanks
-Tariq

  reply	other threads:[~2016-01-08 22:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06  2:27 [Ocfs2-devel] [PATCH] revert to using ocfs2_acl_chmod to avoid inode cluster lock hang Tariq Saeed
2016-01-06  4:41 ` Junxiao Bi
2016-01-07  2:51   ` Tariq Saeed
2016-01-07 22:37     ` Tariq Saeed
2016-01-08  0:13       ` Tariq Saeed
2016-01-07 22:38     ` Tariq Saeed
2016-01-07 22:55 ` Mark Fasheh
2016-01-07 23:49   ` Tariq Saeed
2016-01-08  1:45     ` Mark Fasheh
2016-01-08 22:44       ` Tariq Saeed [this message]
2016-01-11  3:17     ` Junxiao Bi
2016-01-13  2:15       ` Junxiao Bi
  -- strict thread matches above, loose matches on Subject: below --
2016-01-08  1:07 Tariq Saeed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56903BCD.6050806@oracle.com \
    --to=tariq.x.saeed@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.