All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] mraa: new package
Date: Sat, 9 Jan 2016 01:10:51 +0100	[thread overview]
Message-ID: <5690500B.6010302@mind.be> (raw)
In-Reply-To: <1452101054-27957-1-git-send-email-pieterjan.camerlynck@gmail.com>

On 06-01-16 18:24, Pieterjan Camerlynck wrote:
> mraa provides a unified interface for IO on Galileo, Edison,
> Raspberry Pi and others
> 
> Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 One small additional comment below.

[snip]
> diff --git a/package/mraa/mraa.mk b/package/mraa/mraa.mk
> new file mode 100644
> index 0000000..9f3b953
> --- /dev/null
> +++ b/package/mraa/mraa.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# mraa
> +#
> +################################################################################
> +
> +MRAA_VERSION = v0.9.0
> +MRAA_SITE = $(call github,intel-iot-devkit,mraa,$(MRAA_VERSION))
> +MRAA_LICENSE = MIT
> +MRAA_LICENSE_FILES = COPYING
> +MRAA_INSTALL_STAGING = YES
> +

 It might be good to add:

# USBPLAT only makes sense with FTDI4222, which requires the ftd2xx library,
# which doesn't exist in buildroot


 Regards,
 Arnout

> +MRAA_CONF_OPTS += \
> +	-DBUILDSWIG=OFF \
> +	-DUSBPLAT=OFF \
> +	-DFTDI4222=OFF \
> +	-DIPK=OFF \
> +	-DRPM=OFF \
> +	-DENABLEEXAMPLES=OFF \
> +	-DTESTS=OFF
> +
> +$(eval $(cmake-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  parent reply	other threads:[~2016-01-09  0:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 19:46 [Buildroot] [PATCH 1/1] libmraa: new package Pieterjan Camerlynck
2016-01-05  0:48 ` Arnout Vandecappelle
2016-01-05 17:50   ` Pieterjan Camerlynck
2016-01-05 20:11 ` [Buildroot] [PATCH v2] mraa: " Pieterjan Camerlynck
2016-01-06 12:56   ` Samuel Martin
2016-01-06 17:24   ` [Buildroot] [PATCH v3] " Pieterjan Camerlynck
2016-01-06 21:44     ` Samuel Martin
2016-01-09  0:10     ` Arnout Vandecappelle [this message]
2016-01-09  8:36     ` [Buildroot] [PATCH v4 1/1] " Pieterjan Camerlynck
2016-01-12 20:59       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5690500B.6010302@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.