From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754473AbcAILn6 (ORCPT ); Sat, 9 Jan 2016 06:43:58 -0500 Received: from exsmtp03.microchip.com ([198.175.253.49]:58140 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753850AbcAILn4 (ORCPT ); Sat, 9 Jan 2016 06:43:56 -0500 Subject: Re: [PATCH] net: phy: Add support for SMSC LAN8740 PHY To: Andrew Lunn References: <1452301040-4392-1-git-send-email-joshua.henderson@microchip.com> <20160109013655.GA28813@lunn.ch> CC: , Florian Fainelli , From: Joshua Henderson Message-ID: <5690F27A.6090500@microchip.com> Date: Sat, 9 Jan 2016 04:43:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160109013655.GA28813@lunn.ch> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/8/2016 6:36 PM, Andrew Lunn wrote: > On Fri, Jan 08, 2016 at 05:57:20PM -0700, Joshua Henderson wrote: >> LAN8740 has a different phy_id than LAN8710/LAN8720. >> >> Signed-off-by: Joshua Henderson >> --- >> drivers/net/phy/smsc.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c >> index dc2da87..34021a5 100644 >> --- a/drivers/net/phy/smsc.c >> +++ b/drivers/net/phy/smsc.c >> @@ -264,6 +264,29 @@ static struct phy_driver smsc_phy_driver[] = { >> .resume = genphy_resume, >> >> .driver = { .owner = THIS_MODULE, } >> +}, { >> + .phy_id = 0x0007c110, >> + .phy_id_mask = 0xfffffff0, >> + .name = "SMSC LAN8740", >> + >> + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause >> + | SUPPORTED_Asym_Pause), >> + .flags = PHY_HAS_INTERRUPT | PHY_HAS_MAGICANEG, >> + >> + /* basic functions */ >> + .config_aneg = genphy_config_aneg, >> + .read_status = lan87xx_read_status, >> + .config_init = smsc_phy_config_init, >> + .soft_reset = smsc_phy_reset, >> + >> + /* IRQ related */ >> + .ack_interrupt = smsc_phy_ack_interrupt, >> + .config_intr = smsc_phy_config_intr, >> + >> + .suspend = genphy_suspend, >> + .resume = genphy_resume, >> + >> + .driver = { .owner = THIS_MODULE, } >> } }; > > Hi Joshua > > You should remove this .driver line. The core sets it now. > > Andrew > Got it. I'll apply against net-next. Thanks, Josh