From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH net-next v4 06/10] netdev: add netdevice notifier type to trigger a reprogramming of offloads Date: Sat, 9 Jan 2016 18:30:07 +0100 Message-ID: <5691439F.5090500@stressinduktion.org> References: <1452352052-27574-1-git-send-email-hannes@stressinduktion.org> <1452352052-27574-7-git-send-email-hannes@stressinduktion.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Linux Kernel Network Developers , Jesse Gross To: Tom Herbert Return-path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:44311 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753607AbcAIRaK (ORCPT ); Sat, 9 Jan 2016 12:30:10 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id BD4AE20633 for ; Sat, 9 Jan 2016 12:30:09 -0500 (EST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 09.01.2016 18:25, Tom Herbert wrote: > On Sat, Jan 9, 2016 at 7:07 AM, Hannes Frederic Sowa > wrote: >> Signed-off-by: Hannes Frederic Sowa >> --- >> include/linux/netdevice.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> index 8d8e5ca951b493..9750e46760695d 100644 >> --- a/include/linux/netdevice.h >> +++ b/include/linux/netdevice.h >> @@ -2183,6 +2183,7 @@ struct netdev_lag_lower_state_info { >> #define NETDEV_BONDING_INFO 0x0019 >> #define NETDEV_PRECHANGEUPPER 0x001A >> #define NETDEV_CHANGELOWERSTATE 0x001B >> +#define NETDEV_REFRESH_OFFLOADS 0x001C >> > Per previous discussion we don't want to generalize this current > offload interface. Can we just NETDEV_UP as the notifier? The problem with only using NETDEV_UP/REGISTER is that some drivers need to reconfigure their offloads during operation while keeping the netdevice in UP state. One example is ixgbe. This was my first idea also. I am fine with both approaches, my initial submission had two types to notify geneve and vxlan so their doesn't happen any "cross-over". Bye, Hannes