All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: emw@nocabal.de, Martin Witte <emw-linux-media-2016@nocabal.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [REGRESSION/bisected] kernel panic after "rmmod cx23885" by "si2157: implement signal strength stats"
Date: Sun, 10 Jan 2016 05:43:13 +0200	[thread overview]
Message-ID: <5691D351.2030005@iki.fi> (raw)
In-Reply-To: <20160109214237.GA25076@titiwu.nocabal.de>

Hello
Those timers are activated on frontend init() ja de-activated on 
sleep(). Removing active driver does not sound good and IMHO it should 
not be even possible. I think it should be find out why it is possible 
to remove whole driver before it is put to sleep().

Antti


On 01/09/2016 11:42 PM, Ernst Martin Witte wrote:
> Hi again,
>
> seems  that the  cause  for the  kernel  panic is  a  missing call  to
> cancel_delayed_work_sync in  si2157_remove before  the call  to kfree.
> After adding cancel_delayed_work_sync(&dev->stat_work), rmmod does not
> trigger the kernel panic any more.
>
> However, very similar issues could be identified also in other modules:
>
>     ts2020
>     af9013
>     af9033
>     rtl2830
>
> when looking in drivers/media/tuners and drivers/media/dvb-frontends.
>
> Therefore,  the submitted  patch  set contains  fixes  also for  those
> modules. The submitted patch set is:
>
>     [PATCH 0/5] [media] cancel_delayed_work_sync before device removal / kfree
>
> I hope these patches completely fix the issue and are ok for inclusion
> in the kernel.
>
> BR and thx,
>     Martin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

-- 
http://palosaari.fi/

  reply	other threads:[~2016-01-10  3:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 12:18 [REGRESSION/bisected] kernel panic after "rmmod cx23885" by "si2157: implement signal strength stats" Martin Witte
2016-01-09 21:42 ` Ernst Martin Witte
2016-01-10  3:43   ` Antti Palosaari [this message]
2016-01-10 22:04     ` Ernst Martin Witte
2016-01-11  2:34       ` Antti Palosaari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5691D351.2030005@iki.fi \
    --to=crope@iki.fi \
    --cc=emw-linux-media-2016@nocabal.de \
    --cc=emw@nocabal.de \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.