From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757505AbcAJUKI (ORCPT ); Sun, 10 Jan 2016 15:10:08 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:58585 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757348AbcAJUKF (ORCPT ); Sun, 10 Jan 2016 15:10:05 -0500 Subject: Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function To: Andrew Lunn References: <1452357427-30578-1-git-send-email-linux@roeck-us.net> <20160109165802.GD28813@lunn.ch> <56914D21.9050804@roeck-us.net> <20160109205240.GA6877@lunn.ch> <569275C0.1040606@roeck-us.net> <20160110154945.GD22229@lunn.ch> <56928539.1060009@roeck-us.net> <20160110172109.GF22229@lunn.ch> Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <5692BA9B.6020704@roeck-us.net> Date: Sun, 10 Jan 2016 12:10:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160110172109.GF22229@lunn.ch> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/2016 09:21 AM, Andrew Lunn wrote: >> drivers/net/ethernet/amd/au1000_eth.c: /* WARNING: bus->phy_map[phy_addr].attached_dev == dev does >> [ no idea what to do with that comment ] > > That comment is very generic, it applies to all MDIO devices. So i'm > tempted to remove it. I will send a patch, probably tomorrow. > >> drivers/net/ethernet/broadcom/sb1250-mac.c: phy_dev = sc->mii_bus->phy_map[i]; >> [ can use phy_find_first ] > > Yes, phy_find_first. > >> drivers/staging/netlogic/xlr_net.c: struct phy_device *phydev = priv->mii_bus->phy_map[priv->phy_addr]; >> [ several ] > > Odd that i missed that file for phy_map, but did patch it for > phydev_name(). > xlr_net.c also fails to build with drivers/staging/netlogic/xlr_net.c: In function 'xlr_setup_mdio': drivers/staging/netlogic/xlr_net.c:879:21: error: assignment to expression with array type priv->mii_bus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL); This might be related to "mdio: Move allocation of interrupts into core", though I didn't track it down. Guenter