Re: [tip:perf/core] tools lib: Move bitmap.[ch] from tools/perf/ to tools/{lib,include}/

["Wangnan (F)" <wangnan0@huawei.com>]

Hi Arnaldo,

Now its your turn:

you forget to update MANIFEST and it is found by make build-test :)

Thank you.

On 2016/1/10 0:36, tip-bot for Arnaldo Carvalho de Melo wrote:
> Commit-ID:  915b0882c3108a21e9b3b5e176d3151ad522242d
> Gitweb:     http://git.kernel.org/tip/915b0882c3108a21e9b3b5e176d3151ad522242d
> Author:     Arnaldo Carvalho de Melo <acme@redhat.com>
> AuthorDate: Fri, 8 Jan 2016 12:33:37 -0300
> Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
> CommitDate: Fri, 8 Jan 2016 12:35:46 -0300
>
> tools lib: Move bitmap.[ch] from tools/perf/ to tools/{lib,include}/
>
> So that lib/find_bit.c doesn't requires anything inside tools/perf/
>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: George Spelvin <linux@horizon.com
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> Cc: Wang Nan <wangnan0@huawei.com>
> Cc: Yury Norov <yury.norov@gmail.com>
> Link: http://lkml.kernel.org/n/tip-7lxe7jgohaac5faodndhdmvk@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>   tools/{perf/util => }/include/linux/bitmap.h | 0
>   tools/{perf/util => lib}/bitmap.c            | 0
>   tools/perf/util/Build                        | 5 +++++
>   tools/perf/util/python-ext-sources           | 2 +-
>   4 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/include/linux/bitmap.h b/tools/include/linux/bitmap.h
> similarity index 100%
> rename from tools/perf/util/include/linux/bitmap.h
> rename to tools/include/linux/bitmap.h
> diff --git a/tools/perf/util/bitmap.c b/tools/lib/bitmap.c
> similarity index 100%
> rename from tools/perf/util/bitmap.c
> rename to tools/lib/bitmap.c
> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
> index e8bc10b..5eec53a 100644
> --- a/tools/perf/util/Build
> +++ b/tools/perf/util/Build
> @@ -132,6 +132,7 @@ CFLAGS_pmu-bison.o          += -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -w
>   $(OUTPUT)util/parse-events.o: $(OUTPUT)util/parse-events-flex.c $(OUTPUT)util/parse-events-bison.c
>   $(OUTPUT)util/pmu.o: $(OUTPUT)util/pmu-flex.c $(OUTPUT)util/pmu-bison.c
>   
> +CFLAGS_bitmap.o        += -Wno-unused-parameter -DETC_PERFCONFIG="BUILD_STR($(ETC_PERFCONFIG_SQ))"
>   CFLAGS_find_bit.o      += -Wno-unused-parameter -DETC_PERFCONFIG="BUILD_STR($(ETC_PERFCONFIG_SQ))"
>   CFLAGS_rbtree.o        += -Wno-unused-parameter -DETC_PERFCONFIG="BUILD_STR($(ETC_PERFCONFIG_SQ))"
>   CFLAGS_libstring.o     += -Wno-unused-parameter -DETC_PERFCONFIG="BUILD_STR($(ETC_PERFCONFIG_SQ))"
> @@ -142,6 +143,10 @@ $(OUTPUT)util/kallsyms.o: ../lib/symbol/kallsyms.c FORCE
>   	$(call rule_mkdir)
>   	$(call if_changed_dep,cc_o_c)
>   
> +$(OUTPUT)util/bitmap.o: ../lib/bitmap.c FORCE
> +	$(call rule_mkdir)
> +	$(call if_changed_dep,cc_o_c)
> +
>   $(OUTPUT)util/find_bit.o: ../lib/find_bit.c FORCE
>   	$(call rule_mkdir)
>   	$(call if_changed_dep,cc_o_c)
> diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources
> index f15d14f..8162ba0 100644
> --- a/tools/perf/util/python-ext-sources
> +++ b/tools/perf/util/python-ext-sources
> @@ -10,7 +10,7 @@ util/ctype.c
>   util/evlist.c
>   util/evsel.c
>   util/cpumap.c
> -util/bitmap.c
> +../lib/bitmap.c
>   ../lib/find_bit.c
>   ../lib/hweight.c
>   util/thread_map.c