From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-trivial <qemu-trivial@nongnu.org>,
patches@linaro.org
Subject: Re: [Qemu-trivial] [PATCH] scripts/checkpatch.pl: Don't allow special cases of unspaced operators
Date: Mon, 11 Jan 2016 11:12:03 +0300 [thread overview]
Message-ID: <569363D3.3040007@msgid.tls.msk.ru> (raw)
In-Reply-To: <1450443571-14621-1-git-send-email-peter.maydell@linaro.org>
18.12.2015 15:59, Peter Maydell wrote:
> The checkpatch.pl script has a special case to permit the following
> operators to have no spaces around them:
> << >> & ^ | + - * / %
>
> QEMU style prefers all operators to consistently have spacing around
> them, so remove this special case handling. This avoids reviewers
> having to manually note it during code review.
Applied to -trivial, thank you!
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-trivial <qemu-trivial@nongnu.org>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: Don't allow special cases of unspaced operators
Date: Mon, 11 Jan 2016 11:12:03 +0300 [thread overview]
Message-ID: <569363D3.3040007@msgid.tls.msk.ru> (raw)
In-Reply-To: <1450443571-14621-1-git-send-email-peter.maydell@linaro.org>
18.12.2015 15:59, Peter Maydell wrote:
> The checkpatch.pl script has a special case to permit the following
> operators to have no spaces around them:
> << >> & ^ | + - * / %
>
> QEMU style prefers all operators to consistently have spacing around
> them, so remove this special case handling. This avoids reviewers
> having to manually note it during code review.
Applied to -trivial, thank you!
/mjt
next prev parent reply other threads:[~2016-01-11 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 12:59 [Qemu-devel] [PATCH] scripts/checkpatch.pl: Don't allow special cases of unspaced operators Peter Maydell
2015-12-18 13:03 ` Paolo Bonzini
2015-12-18 13:08 ` [Qemu-trivial] " Stefan Weil
2015-12-18 13:08 ` Stefan Weil
2015-12-18 15:31 ` Eric Blake
2016-01-11 8:12 ` Michael Tokarev [this message]
2016-01-11 8:12 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569363D3.3040007@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=blauwirbel@gmail.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.