From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH 6/6] regulator: max77620: add regulator driver for max77620/max20024 Date: Mon, 11 Jan 2016 15:46:30 +0530 Message-ID: <569380FE.6020609@nvidia.com> References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-7-git-send-email-ldewangan@nvidia.com> <20160110124014.GZ6588@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160110124014.GZ6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, Mallikarjun Kasoju List-Id: linux-gpio@vger.kernel.org Thanks Mark for review. I have query in one of comment. On Sunday 10 January 2016 06:10 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Thu, Jan 07, 2016 at 08:08:44PM +0530, Laxman Dewangan wrote: > > > + np = of_get_child_by_name(pdev->dev.parent->of_node, "regulators"); > + if (!np) { > + dev_err(&pdev->dev, "Device is not having regulators node\n"); > + return -ENODEV; > + } > + pdev->dev.of_node = np; > + > + ret = of_regulator_match(&pdev->dev, np, max77620_regulator_matches, > + ARRAY_SIZE(max77620_regulator_matches)); > + if (ret < 0) { > + dev_err(&pdev->dev, "Parsing of regulator node failed: %d\n", > + ret); > + return ret; > + } > Don't open code this, use the core support via regulators and of_match. > I did not get this point? Here I am using the of_regulator_match from core? Can you please help to explain this? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com. [216.228.121.64]) by gmr-mx.google.com with ESMTPS id 190si620366pfb.1.2016.01.11.02.26.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jan 2016 02:26:46 -0800 (PST) Message-ID: <569380FE.6020609@nvidia.com> Date: Mon, 11 Jan 2016 15:46:30 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Mark Brown CC: , , , , , , , , , , , , , , , , , Mallikarjun Kasoju Subject: [rtc-linux] Re: [PATCH 6/6] regulator: max77620: add regulator driver for max77620/max20024 References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-7-git-send-email-ldewangan@nvidia.com> <20160110124014.GZ6588@sirena.org.uk> In-Reply-To: <20160110124014.GZ6588@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Thanks Mark for review. I have query in one of comment. On Sunday 10 January 2016 06:10 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Thu, Jan 07, 2016 at 08:08:44PM +0530, Laxman Dewangan wrote: > > > + np = of_get_child_by_name(pdev->dev.parent->of_node, "regulators"); > + if (!np) { > + dev_err(&pdev->dev, "Device is not having regulators node\n"); > + return -ENODEV; > + } > + pdev->dev.of_node = np; > + > + ret = of_regulator_match(&pdev->dev, np, max77620_regulator_matches, > + ARRAY_SIZE(max77620_regulator_matches)); > + if (ret < 0) { > + dev_err(&pdev->dev, "Parsing of regulator node failed: %d\n", > + ret); > + return ret; > + } > Don't open code this, use the core support via regulators and of_match. > I did not get this point? Here I am using the of_regulator_match from core? Can you please help to explain this? -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759308AbcAKK0r (ORCPT ); Mon, 11 Jan 2016 05:26:47 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:18493 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758964AbcAKK0q (ORCPT ); Mon, 11 Jan 2016 05:26:46 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 11 Jan 2016 02:22:20 -0800 Message-ID: <569380FE.6020609@nvidia.com> Date: Mon, 11 Jan 2016 15:46:30 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Mark Brown CC: , , , , , , , , , , , , , , , , , Mallikarjun Kasoju Subject: Re: [PATCH 6/6] regulator: max77620: add regulator driver for max77620/max20024 References: <1452177524-23192-1-git-send-email-ldewangan@nvidia.com> <1452177524-23192-7-git-send-email-ldewangan@nvidia.com> <20160110124014.GZ6588@sirena.org.uk> In-Reply-To: <20160110124014.GZ6588@sirena.org.uk> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Mark for review. I have query in one of comment. On Sunday 10 January 2016 06:10 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Thu, Jan 07, 2016 at 08:08:44PM +0530, Laxman Dewangan wrote: > > > + np = of_get_child_by_name(pdev->dev.parent->of_node, "regulators"); > + if (!np) { > + dev_err(&pdev->dev, "Device is not having regulators node\n"); > + return -ENODEV; > + } > + pdev->dev.of_node = np; > + > + ret = of_regulator_match(&pdev->dev, np, max77620_regulator_matches, > + ARRAY_SIZE(max77620_regulator_matches)); > + if (ret < 0) { > + dev_err(&pdev->dev, "Parsing of regulator node failed: %d\n", > + ret); > + return ret; > + } > Don't open code this, use the core support via regulators and of_match. > I did not get this point? Here I am using the of_regulator_match from core? Can you please help to explain this?