From: Mason <slash.tmp@free.fr>
To: Kishon Vijay Abraham I <kishon@ti.com>, Felipe Balbi <balbi@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-usb <linux-usb@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: Correct place for USB PHY driver
Date: Mon, 11 Jan 2016 12:56:27 +0100 [thread overview]
Message-ID: <5693986B.6050204@free.fr> (raw)
In-Reply-To: <569383BB.3030400@ti.com>
On 11/01/2016 11:28, Kishon Vijay Abraham I wrote:
> On Monday 11 January 2016 03:37 PM, Mason wrote:
>
>> I have a board with a Chipidea controller.
>> I use a custom PHY driver for it.
>>
>> Should the PHY driver live in drivers/phy or in drivers/usb/phy ?
>
> All new phy drivers should be in drivers/phy using the generic PHY framework.
>
>> I was playing with a modular build and hit this problem:
>> ERROR: "of_usb_get_phy_mode" [drivers/usb/chipidea/ci_hdrc.ko] undefined!
>>
>> I'm currently using v4.1.13 and I saw that Arnd fixed something related
>> probably in a later version:
>>
>> http://thread.gmane.org/gmane.linux.ports.arm.kernel/457561
>>
>> Was this patch accepted upstream?
>
> I think no.
The driver I use is in drivers/phy and my config has
CONFIG_GENERIC_PHY=y
# CONFIG_USB_PHY is not set
But I do hit the "of_usb_get_phy_mode undefined" error when I
set all of USB to m.
Arnd, do you think your patch needs to be carried over to generic PHY?
Regards.
next prev parent reply other threads:[~2016-01-11 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 10:07 Correct place for USB PHY driver Mason
2016-01-11 10:28 ` Kishon Vijay Abraham I
2016-01-11 11:56 ` Mason [this message]
2016-01-11 13:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5693986B.6050204@free.fr \
--to=slash.tmp@free.fr \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.