From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759740AbcAKMXg (ORCPT ); Mon, 11 Jan 2016 07:23:36 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:49479 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758017AbcAKMXb (ORCPT ); Mon, 11 Jan 2016 07:23:31 -0500 Message-ID: <56939EAD.4090003@huawei.com> Date: Mon, 11 Jan 2016 20:23:09 +0800 From: wanghaibin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Tejun Heo CC: , , Subject: Re: [RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device References: <1452170339-26748-1-git-send-email-wanghaibin.wang@huawei.com> <1452170339-26748-4-git-send-email-wanghaibin.wang@huawei.com> <20160107160005.GC1898@mtj.duckdns.org> In-Reply-To: <20160107160005.GC1898@mtj.duckdns.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.144] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.56939EBC.00EA,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 13d9ee4d4df51581e52820016affa51c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/8 0:00, Tejun Heo wrote: > On Thu, Jan 07, 2016 at 08:38:58PM +0800, wanghaibin wrote: >> for workqueue's flag with the WQ_SYSFS | WQ_UNBOUND, the wq_dev will create some sys_files for >> unbound attrs, so, remove the unbind workqueue attrs sys_files before unregister the >> workqueue device. > > File removal on sysfs is recursive, right? Does explicitly removing > file make any difference? Yes, It has been removed already, I made a mistake. Thanks. >