From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933042AbcAKOZy (ORCPT ); Mon, 11 Jan 2016 09:25:54 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:32872 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759119AbcAKOZw (ORCPT ); Mon, 11 Jan 2016 09:25:52 -0500 Subject: Re: [PATCH 11/53] perf test: Fix false TEST_OK result for 'perf test hist' To: Wang Nan , acme@kernel.org References: <1452520124-2073-1-git-send-email-wangnan0@huawei.com> <1452520124-2073-12-git-send-email-wangnan0@huawei.com> Cc: linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com, netdev@vger.kernel.org, davem@davemloft.net, Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <5693BB6C.9060900@cogentembedded.com> Date: Mon, 11 Jan 2016 17:25:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1452520124-2073-12-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2016 04:48 PM, Wang Nan wrote: > Commit 71d6de64feddd4b455555326fba2111b3006d9e0 ('perf test: Fix hist > testcases when kptr_restrict is on') solves a double free problem when You didn't run this patch thru scripts/checkpatch.pl, I guess? A certain commit citing style is enforced now, and yours doesn't quite match it... > 'perf test hist' calling setup_fake_machine(). However, the result is > still incorrect. For example: > > $ ./perf test -v 'filtering hist entries' > 25: Test filtering hist entries : > --- start --- > test child forked, pid 4186 > Cannot create kernel maps > test child finished with 0 > ---- end ---- > Test filtering hist entries: Ok > > In this case the body of this test is not get executed at all, but the > result is 'Ok'. > > Actually, in setup_fake_machine() there's no need to create real kernel > maps. What we want is the fake maps. This patch removes the > machine__create_kernel_maps() in setup_fake_machine(), so it won't be > affected by kptr_restrict setting. > > Test result: > > $ cat /proc/sys/kernel/kptr_restrict > 1 > $ ~/perf test -v hist > 15: Test matching and linking multiple hists : > --- start --- > test child forked, pid 24031 > test child finished with 0 > ---- end ---- > Test matching and linking multiple hists: Ok > [SNIP] > > Signed-off-by: Wang Nan > Suggested-by: Namhyung Kim > Acked-by: Namhyung Kim > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Masami Hiramatsu [...] MBR, Sergei