All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Doug Goldstein <cardoe@cardoe.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen/spinlock: Use mnemonics for recursive spinlock sentinel values
Date: Mon, 11 Jan 2016 15:35:48 +0000	[thread overview]
Message-ID: <5693CBD4.60806@citrix.com> (raw)
In-Reply-To: <5693C80C02000078000C5716@prv-mh.provo.novell.com>

On 11/01/16 14:19, Jan Beulich wrote:
>>>> On 09.01.16 at 15:33, <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/common/spinlock.c
>> +++ b/xen/common/spinlock.c
>> @@ -246,7 +246,7 @@ int _spin_trylock_recursive(spinlock_t *lock)
>>      unsigned int cpu = smp_processor_id();
>>  
>>      /* Don't allow overflow of recurse_cpu field. */
>> -    BUILD_BUG_ON(NR_CPUS > 0xfffu);
>> +    BUILD_BUG_ON(NR_CPUS >= SPINLOCK_NO_CPU);
> ">" (see also the reply to Doug's patch 1/2)

So it is.

As there is no bug, I will resubmit the cleanup when the NR_CPUS series
is in to avoid causing patch conflicts.

~Andrew

      reply	other threads:[~2016-01-11 15:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-09 14:33 [PATCH] xen/spinlock: Use mnemonics for recursive spinlock sentinel values Andrew Cooper
2016-01-11 14:19 ` Jan Beulich
2016-01-11 15:35   ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5693CBD4.60806@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=cardoe@cardoe.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.