From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIeXP-0003dt-HJ for qemu-devel@nongnu.org; Mon, 11 Jan 2016 10:37:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIeXM-0007I3-8z for qemu-devel@nongnu.org; Mon, 11 Jan 2016 10:37:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:50515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIeXL-0007Hw-Qt for qemu-devel@nongnu.org; Mon, 11 Jan 2016 10:37:40 -0500 References: <1450452647-118105-1-git-send-email-imammedo@redhat.com> <1450452647-118105-2-git-send-email-imammedo@redhat.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <5693CC40.4060806@suse.de> Date: Mon, 11 Jan 2016 16:37:36 +0100 MIME-Version: 1.0 In-Reply-To: <1450452647-118105-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] qom: add object_class_get_instance_size() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, armbru@redhat.com Am 18.12.2015 um 16:30 schrieb Igor Mammedov: > it will be used for allocating memory for a to be > created new object in safe manner. >=20 > Signed-off-by: Igor Mammedov > --- > include/qom/object.h | 8 ++++++++ > qom/object.c | 5 +++++ > 2 files changed, 13 insertions(+) >=20 > diff --git a/include/qom/object.h b/include/qom/object.h > index 4509166..8f61b0b 100644 > --- a/include/qom/object.h > +++ b/include/qom/object.h > @@ -880,6 +880,14 @@ bool object_class_is_abstract(ObjectClass *klass); > */ > ObjectClass *object_class_by_name(const char *typename); > =20 > +/** > + * object_class_get_instance_size: > + * @klass: The #ObjectClass to obtain instance size > + * > + * Returns: instance size of @klass > + */ > +size_t object_class_get_instance_size(ObjectClass *klass); > + > void object_class_foreach(void (*fn)(ObjectClass *klass, void *opaque)= , > const char *implements_type, bool include_ab= stract, > void *opaque); > diff --git a/qom/object.c b/qom/object.c > index d751569..2f141ee 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -771,6 +771,11 @@ ObjectClass *object_class_get_parent(ObjectClass *= class) > return type->class; > } > =20 > +size_t object_class_get_instance_size(ObjectClass *klass) > +{ > + return klass->type->instance_size; > +} > + > typedef struct OCFData > { > void (*fn)(ObjectClass *klass, void *opaque); I had previously proposed a type_get_instance_size() but did not get any feedback: http://patchwork.ozlabs.org/patch/269591/ It was using name -> type, here you are using class -> type. One does not necessarily exclude the other. :) Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)