All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Grant Edwards <grant.b.edwards@gmail.com>, linux-kernel@vger.kernel.org
Cc: linux-serial@vger.kernel.org,
	Greg KH <gregkh@linuxfoundation.org>,
	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Jiri Slaby <jslaby@suse.cz>
Subject: Re: RFC: out-of-tree tty driver breakage (changing ASYNC_ bits)
Date: Mon, 11 Jan 2016 08:24:13 -0800	[thread overview]
Message-ID: <5693D72D.6050501@hurleysoftware.com> (raw)
In-Reply-To: <n70j5g$sem$1@ger.gmane.org>

On 01/11/2016 07:53 AM, Grant Edwards wrote:
> On 2016-01-11, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Sun, Jan 10, 2016 at 01:42:44PM -0800, Peter Hurley wrote:
>>
>>> This will break out-of-tree drivers but I don't really see a
>>> realistic alternative. Also, I think the new symbol prefix ASY_ isn't
>>> great and I'd like to get some suggestions.
>>
>> Don't worry about breaking out-of-tree drivers, that's fine.
> 
> One request from this maintainer of several out-of-tree drivers: if
> you break something, break it such that it won't compile.  It would be
> nice to avoid changes that break functionality but still compile
> without warning.

I was in the process of writing how I can't remove ASYNC_INITIALIZED, et.al
from the uapi header, when I realized that I can just guard them with
#ifndef _KERNEL_ which will trigger the requisite out-of-tree build
break.

Regards,
Peter Hurley

  reply	other threads:[~2016-01-11 16:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-10 21:42 RFC: out-of-tree tty driver breakage (changing ASYNC_ bits) Peter Hurley
2016-01-10 23:44 ` One Thousand Gnomes
2016-01-11  0:36   ` Peter Hurley
2016-01-11  4:42 ` Greg KH
2016-01-11  5:16   ` Peter Hurley
2016-01-11 15:53   ` Grant Edwards
2016-01-11 16:24     ` Peter Hurley [this message]
2016-06-28 15:39       ` Grant Edwards
2016-06-28 15:54         ` Grant Edwards
2016-06-28 16:05           ` Grant Edwards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5693D72D.6050501@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=grant.b.edwards@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.