From: John Snow <jsnow@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, P J P <ppandit@redhat.com>
Cc: Qinghao Tang <luodalongde@gmail.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Prasad J Pandit <pjp@fedoraproject.org>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2] ide: ahci: reset ncq object to unused on error
Date: Mon, 11 Jan 2016 11:28:15 -0500 [thread overview]
Message-ID: <5693D81F.20704@redhat.com> (raw)
In-Reply-To: <20160111150013.GB9454@noname.redhat.com>
On 01/11/2016 10:00 AM, Kevin Wolf wrote:
> Am 08.01.2016 um 20:48 hat P J P geschrieben:
>> From: Prasad J Pandit <pjp@fedoraproject.org>
>>
>> When processing NCQ commands, ACHI device emulation prepares a
>
> s/ACHI/AHCI/
>
> Can you still fix this in your tree, John?
>
> Kevin
>
Yes, thanks.
>> NCQ transfer object; To which an aio control block(aiocb) object
>> is assigned in 'execute_ncq_command'. In case, when the NCQ
>> command is invalid, the 'aiocb' object is not assigned, and NCQ
>> transfer object is left as 'used'. This leads to a use after
>> free kind of error in 'bdrv_aio_cancel_async' via 'ahci_reset_port'.
>> Reset NCQ transfer object to 'unused' to avoid it.
>>
>> Reported-by: Qinghao Tang <luodalongde@gmail.com>
>> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
>
next prev parent reply other threads:[~2016-01-11 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 19:48 [Qemu-devel] [PATCH v2] ide: ahci: reset ncq object to unused on error P J P
2016-01-08 19:54 ` John Snow
2016-01-08 20:07 ` John Snow
2016-01-09 4:16 ` P J P
2016-01-11 15:00 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2016-01-11 16:28 ` John Snow [this message]
2016-01-11 17:09 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5693D81F.20704@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=luodalongde@gmail.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.