From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIoaY-0004lV-B0 for qemu-devel@nongnu.org; Mon, 11 Jan 2016 21:21:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIoaU-0006ac-0h for qemu-devel@nongnu.org; Mon, 11 Jan 2016 21:21:38 -0500 Received: from [59.151.112.132] (port=62125 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIoaT-0006ZH-K7 for qemu-devel@nongnu.org; Mon, 11 Jan 2016 21:21:33 -0500 References: <1450436632-23980-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1450436632-23980-3-git-send-email-caoj.fnst@cn.fujitsu.com> <20151218183700.GZ3774@thinpad.lan.raisama.net> <87poy3wj4u.fsf@blackfin.pond.sub.org> <56769807.5010809@cn.fujitsu.com> <87d1t8xk3i.fsf@blackfin.pond.sub.org> From: Cao jin Message-ID: <569463E9.5010009@cn.fujitsu.com> Date: Tue, 12 Jan 2016 10:24:41 +0800 MIME-Version: 1.0 In-Reply-To: <87d1t8xk3i.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] igd-passthrough-i440FX: convert to realize() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Eduardo Habkost , mst@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net On 01/11/2016 10:32 PM, Markus Armbruster wrote: > Cao jin writes: [...] >>> >> >> Ok...will change the error msg to strerror(errno) > > There's also error_setg_file_open(), not sure it fits here, but check it > out. > Thanks for reminding. Gerd Hoffmann has whole patchset(http://lists.nongnu.org/archive/html/qemu-devel/2016-01/msg00245.html) which covers this, so maybe this doesn`t need to be updated. -- Yours Sincerely, Cao jin