From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761478AbcALENq (ORCPT ); Mon, 11 Jan 2016 23:13:46 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:8114 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761194AbcALENo (ORCPT ); Mon, 11 Jan 2016 23:13:44 -0500 Message-ID: <56947D55.1080804@huawei.com> Date: Tue, 12 Jan 2016 12:13:09 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: , , , , , Will Deacon , Jiri Olsa Subject: Re: [PATCH 17/53] perf test: Improve bp_signal References: <1452520124-2073-1-git-send-email-wangnan0@huawei.com> <1452520124-2073-18-git-send-email-wangnan0@huawei.com> <20160111213729.GI18367@kernel.org> In-Reply-To: <20160111213729.GI18367@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.56947D75.0029,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 8d763cf61dc1e4be3d8480dd3a0b26b7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/12 5:37, Arnaldo Carvalho de Melo wrote: > Em Mon, Jan 11, 2016 at 01:48:08PM +0000, Wang Nan escreveu: >> Will Deacon [1] has some question on patch [2]. This patch improves >> test__bp_signal so we can test: >> >> 1. A watchpoint and a breakpoint that fire on the same instruction >> 2. Nested signals >> >> Test result: >> >> On x86_64 and ARM64 (result are similar with patch [2] on ARM64): >> >> # ./perf test -v signal >> 17: Test breakpoint overflow signal handler : >> --- start --- >> test child forked, pid 10213 >> count1 1, count2 3, count3 2, overflow 3, overflows_2 3 >> test child finished with 0 >> ---- end ---- >> Test breakpoint overflow signal handler: Ok >> >> So at least 2 cases Will doubted are handled correctly. >> >> [1] http://lkml.kernel.org/g/20160104165535.GI1616@arm.com >> [2] http://lkml.kernel.org/g/1450921362-198371-1-git-send-email-wangnan0@huawei.com >> >> Signed-off-by: Wang Nan >> Cc: Will Deacon > Will, are you ok with this one? Can I have an Acked-by or better, > Tested-by for the AARCH64 base? Patch [2] is still in question. On AArch64 this test will fail even without this patch. Thank you.