From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIrKa-0007Wh-P6 for qemu-devel@nongnu.org; Tue, 12 Jan 2016 00:17:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIrKW-0002WM-4g for qemu-devel@nongnu.org; Tue, 12 Jan 2016 00:17:20 -0500 Received: from [59.151.112.132] (port=40214 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIrKV-0002W0-M5 for qemu-devel@nongnu.org; Tue, 12 Jan 2016 00:17:16 -0500 References: <1452087621-32574-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Cao jin Message-ID: <56948D0C.4060906@cn.fujitsu.com> Date: Tue, 12 Jan 2016 13:20:12 +0800 MIME-Version: 1.0 In-Reply-To: <1452087621-32574-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] SPARC ebus: QOMify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, mark.cave-ayland@ilande.co.uk ping? On 01/06/2016 09:40 PM, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/sparc64/sun4u.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c > index d6b929c..07f74fe 100644 > --- a/hw/sparc64/sun4u.c > +++ b/hw/sparc64/sun4u.c > @@ -98,6 +98,10 @@ typedef struct EbusState { > MemoryRegion bar1; > } EbusState; > > +#define TYPE_EBUS_BRIDGE "ebus" > +#define EBUS_PCI_BRIDGE(obj) \ > + OBJECT_CHECK(EbusState, (obj), TYPE_EBUS_BRIDGE) > + > int DMA_get_channel_mode (int nchan) > { > return 0; > @@ -586,7 +590,7 @@ pci_ebus_init(PCIBus *bus, int devfn, qemu_irq *irqs) > PCIDevice *pci_dev; > ISABus *isa_bus; > > - pci_dev = pci_create_simple(bus, devfn, "ebus"); > + pci_dev = pci_create_simple(bus, devfn, TYPE_EBUS_BRIDGE); > isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); > isa_irq = qemu_allocate_irqs(isa_irq_handler, irqs, 16); > isa_bus_irqs(isa_bus, isa_irq); > @@ -629,7 +633,7 @@ static void ebus_class_init(ObjectClass *klass, void *data) > } > > static const TypeInfo ebus_info = { > - .name = "ebus", > + .name = TYPE_EBUS_BRIDGE, > .parent = TYPE_PCI_DEVICE, > .instance_size = sizeof(EbusState), > .class_init = ebus_class_init, > -- Yours Sincerely, Cao jin