From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933050AbcALHT0 (ORCPT ); Tue, 12 Jan 2016 02:19:26 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:4064 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760409AbcALHTY (ORCPT ); Tue, 12 Jan 2016 02:19:24 -0500 Message-ID: <5694A838.6030307@huawei.com> Date: Tue, 12 Jan 2016 15:16:08 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: , , , , , Jiri Olsa , Namhyung Kim Subject: Re: [PATCH 05/53] perf tools: Test correct path of perf in build-test References: <1452520124-2073-1-git-send-email-wangnan0@huawei.com> <1452520124-2073-6-git-send-email-wangnan0@huawei.com> <20160111152456.GC18367@kernel.org> <20160111220618.GK18367@kernel.org> <20160111223904.GL18367@kernel.org> <20160111223954.GM18367@kernel.org> In-Reply-To: <20160111223954.GM18367@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.5694A8D8.00D3,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d0d282f7ba545d8276a5d23fb73b1e9c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/12 6:39, Arnaldo Carvalho de Melo wrote: > Em Mon, Jan 11, 2016 at 07:39:04PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Mon, Jan 11, 2016 at 07:06:18PM -0300, Arnaldo Carvalho de Melo escreveu: >>> Em Mon, Jan 11, 2016 at 12:24:56PM -0300, Arnaldo Carvalho de Melo escreveu: >>>> Em Mon, Jan 11, 2016 at 01:47:56PM +0000, Wang Nan escreveu: >>>>> If an 'O' is passed to 'make build-test', many 'test -x' and 'test -f' >>>>> will fail because perf resides in a different directory. Fix this by >>>>> computing PERF_OUT according to 'O' and test correct output files. >>>>> For make_kernelsrc and make_kernelsrc_tools, set KBUILD_OUTPUT_DIR >>>>> instead because the path is different from others ($(O)/perf vs >>>>> $(O)/tools/perf). >>>> Ok, applying up to this patch I now manage to almost cleanly build it using O=, >>>> see below, but seems that we have some race, as not all tests end up producing >>>> such warnings. >>>> >>>> [acme@felicio linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make O=/tmp/build/perf -C tools/perf build-test >>>> make: Entering directory `/home/acme/git/linux/tools/perf' >>>> Testing Makefile >>>> - make_no_libperl: cd . && make -f Makefile DESTDIR=/tmp/tmp.m1nXBMqhSA NO_LIBPERL=1 >>>> find: ‘/tmp/build/perf/util/trace-event-scripting.o’: No such file or directory This can happen when you parallelly run find and rm on one directory. However, I've never seen this message in build-test before. >>> Well, it is happening even without O=: >> So I removed a few patches and those aren't appearing anymore, please >> take a look at my perf/core branch, running build-test on a few machines >> now, will push soon. >> >> My hunch is that build-test has issues with parallel builds, but I'm not >> sure... > > Good: > > - make_perf_o_O: cd . && make -f Makefile O=/tmp/tmp.oLeg8aUaOo DESTDIR=/tmp/tmp.16WP4HTQJs perf.o > - make_util_pmu_bison_o_O: cd . && make -f Makefile O=/tmp/tmp.xNRV0pCXfD DESTDIR=/tmp/tmp.8dyU9uEbHe util/pmu-bison.o > - make_no_libdw_dwarf_unwind_O: cd . && make -f Makefile O=/tmp/tmp.pHH4HExHcH DESTDIR=/tmp/tmp.Wo0m8fF5cp NO_LIBDW_DWARF_UNWIND=1 > - make_no_demangle_O: cd . && make -f Makefile O=/tmp/tmp.yWNsd4jOsI DESTDIR=/tmp/tmp.Q7eA4kCvwL NO_DEMANGLE=1 > - tarpkg: ./tests/perf-targz-src-pkg . > - make -C tools/perf > - make -C /tools perf > OK Glad to see this. Thank you.