From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1761646AbcALHlK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jan 2016 02:41:10 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:23621 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1761516AbcALHk5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jan 2016 02:40:57 -0500
Message-ID: <5694ADF8.3080403@huawei.com>
Date: Tue, 12 Jan 2016 15:40:40 +0800
From: "Wangnan (F)" <wangnan0@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <pi3orama@163.com>, <lizefan@huawei.com>,
        <netdev@vger.kernel.org>, <davem@davemloft.net>
Subject: Re: [PATCH 14/53] perf test: Check environment before start real
 BPF test
References: <1452520124-2073-1-git-send-email-wangnan0@huawei.com> <1452520124-2073-15-git-send-email-wangnan0@huawei.com> <20160111215503.GJ18367@kernel.org>
In-Reply-To: <20160111215503.GJ18367@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020203.5694AE03.007F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: d281536420facee61c66dc7de0236197
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/1/12 5:55, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jan 11, 2016 at 01:48:05PM +0000, Wang Nan escreveu:
>> Copying perf to old kernel system results:
>>
>>   # perf test bpf
>>   37: Test BPF filter                                          :
>>   37.1: Test basic BPF filtering                               : FAILED!
>>   37.2: Test BPF prologue generation                           : Skip
>>
>> However, in case when kernel doesn't support a test case it should
>> return 'Skip', 'FAILED!' should be reserved for kernel tests for when
>> the kernel supports a feature that then fails to work as advertised.
>>
>> This patch checks environment before real testcase.
> This is really strange, this other test is failing if the above patch is
> present, found by bisecting:
>
> [acme@felicio linux]$ perf test decoder
> 47: Test x86 instruction decoder - new instructions          : FAILED!
> [acme@felicio linux]$ git log --oneline -1
> 91fedd318e3d perf test: Check environment before start real BPF test
> [acme@felicio linux]$ git reset --hard HEAD^
> HEAD is now at f1f23526d3b6 perf test: Reset err after using it hold
> errcode in hist testcases
> [acme@felicio linux]$ m
> make: Entering directory `/home/acme/git/linux/tools/perf'
>    BUILD:   Doing 'make -j4' parallel build
>    CC       /tmp/build/perf/arch/common.o
>    CC       /tmp/build/perf/util/abspath.o
>    CC       /tmp/build/perf/builtin-bench.o
>    CC       /tmp/build/perf/util/alias.o
>
> <SNIP>
> [acme@felicio linux]$ git log --oneline -1
> f1f23526d3b6 perf test: Reset err after using it hold errcode in hist
> testcases
> [acme@felicio linux]$ perf test decoder
> 47: Test x86 instruction decoder - new instructions          : Ok
> [acme@felicio linux]$

Yes, really strange, and I can't reproduce your result
in my environment. What's the result of test -v?

Thank you.