From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrille Pitchen Subject: Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice Date: Tue, 12 Jan 2016 09:39:41 +0100 Message-ID: <5694BBCD.8020700@atmel.com> References: <1452528102-26458-1-git-send-email-mans@mansr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE To: Mans Rullgard , , "Yang, Wenyou" , Nicolas Ferre , Mark Brown , , Return-path: In-Reply-To: <1452528102-26458-1-git-send-email-mans-2StjZFpD7GcAvxtiuMwx3w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hi Mans, I've tried to apply your patch on a next-20160112 branch to test it but= it failed. I've also looked at the for-next branch of the SPI sub-system g= it tree. It seems that one issue occurred within a chunk patching the atmel_spi_= setup() function. Please see below. Le 11/01/2016 17:01, Mans Rullgard a =E9crit : [...] > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 08cbb3e43c76..d4a806e24060 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c [...] > @@ -1603,6 +1611,7 @@ static int atmel_spi_setup(struct spi_device *s= pi) > } > =20 > asd->npcs_pin =3D npcs_pin; > + asd->use_cs_gpio =3D use_cs_gpio; > spi->controller_state =3D asd; > } else { > atmel_spi_lock(as); [...] There is no 'else' statement in the source code I'm looking at. Best regards, Cyrille -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: cyrille.pitchen@atmel.com (Cyrille Pitchen) Date: Tue, 12 Jan 2016 09:39:41 +0100 Subject: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice In-Reply-To: <1452528102-26458-1-git-send-email-mans@mansr.com> References: <1452528102-26458-1-git-send-email-mans@mansr.com> Message-ID: <5694BBCD.8020700@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mans, I've tried to apply your patch on a next-20160112 branch to test it but it failed. I've also looked at the for-next branch of the SPI sub-system git tree. It seems that one issue occurred within a chunk patching the atmel_spi_setup() function. Please see below. Le 11/01/2016 17:01, Mans Rullgard a ?crit : [...] > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 08cbb3e43c76..d4a806e24060 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c [...] > @@ -1603,6 +1611,7 @@ static int atmel_spi_setup(struct spi_device *spi) > } > > asd->npcs_pin = npcs_pin; > + asd->use_cs_gpio = use_cs_gpio; > spi->controller_state = asd; > } else { > atmel_spi_lock(as); [...] There is no 'else' statement in the source code I'm looking at. Best regards, Cyrille From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934091AbcALIjr (ORCPT ); Tue, 12 Jan 2016 03:39:47 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:20992 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933757AbcALIjp (ORCPT ); Tue, 12 Jan 2016 03:39:45 -0500 Subject: Re: [PATCH v2] spi: atmel: improve internal vs gpio chip-select choice To: Mans Rullgard , , "Yang, Wenyou" , Nicolas Ferre , Mark Brown , , References: <1452528102-26458-1-git-send-email-mans@mansr.com> From: Cyrille Pitchen Message-ID: <5694BBCD.8020700@atmel.com> Date: Tue, 12 Jan 2016 09:39:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1452528102-26458-1-git-send-email-mans@mansr.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mans, I've tried to apply your patch on a next-20160112 branch to test it but it failed. I've also looked at the for-next branch of the SPI sub-system git tree. It seems that one issue occurred within a chunk patching the atmel_spi_setup() function. Please see below. Le 11/01/2016 17:01, Mans Rullgard a écrit : [...] > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 08cbb3e43c76..d4a806e24060 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c [...] > @@ -1603,6 +1611,7 @@ static int atmel_spi_setup(struct spi_device *spi) > } > > asd->npcs_pin = npcs_pin; > + asd->use_cs_gpio = use_cs_gpio; > spi->controller_state = asd; > } else { > atmel_spi_lock(as); [...] There is no 'else' statement in the source code I'm looking at. Best regards, Cyrille