From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934487AbcALIqE (ORCPT ); Tue, 12 Jan 2016 03:46:04 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:34972 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934450AbcALIqB (ORCPT ); Tue, 12 Jan 2016 03:46:01 -0500 Subject: Re: [PATCH] uapi: update install list after nvme.h rename To: Mike Frysinger , linux-kernel@vger.kernel.org References: <1452474851-386-1-git-send-email-vapier@gentoo.org> Cc: hch@lst.de, keith.busch@intel.com, axboe@fb.com, stable@vger.kernel.org From: Jiri Slaby Message-ID: <5694BD46.3030004@suse.cz> Date: Tue, 12 Jan 2016 09:45:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1452474851-386-1-git-send-email-vapier@gentoo.org> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2016, 02:14 AM, Mike Frysinger wrote: > Commit 9d99a8dda154 ("nvme: move hardware structures out of the uapi > version of nvme.h") renamed nvme.h to nvme_ioctl.h, but the uapi list > still refers to nvme.h. People trying to install the headers hit a > failure as the header no longer exists. Wouldn't reverting the rename be nicer to userspace? So that the filename is preserved and anybody who #included nvme.h still can do so? > Cc: stable@vger.kernel.org > Signed-off-by: Mike Frysinger > --- > include/uapi/linux/Kbuild | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild > index dc6172c..7bb6aeb 100644 > --- a/include/uapi/linux/Kbuild > +++ b/include/uapi/linux/Kbuild > @@ -307,7 +307,7 @@ header-y += nfs_mount.h > header-y += nl80211.h > header-y += n_r3964.h > header-y += nubus.h > -header-y += nvme.h > +header-y += nvme_ioctl.h > header-y += nvram.h > header-y += omap3isp.h > header-y += omapfb.h > -- js suse labs