From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934694AbcALKvu (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jan 2016 05:51:50 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:22026 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933125AbcALKvs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jan 2016 05:51:48 -0500
Message-ID: <5694DA9B.6080704@huawei.com>
Date: Tue, 12 Jan 2016 18:51:07 +0800
From: "Wangnan (F)" <wangnan0@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: =?UTF-8?B?5bmz5p2+6ZuF5bezIC8gSElSQU1BVFXvvIxNQVNBTUk=?= 
	<masami.hiramatsu.pt@hitachi.com>,
        "acme@kernel.org" <acme@kernel.org>
CC: "jolsa@kernel.org" <jolsa@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        He Kuang <hekuang@huawei.com>, Namhyung Kim <namhyung@kernel.org>,
        Zefan Li <lizefan@huawei.com>, "pi3orama@163.com" <pi3orama@163.com>
Subject: Re: [PATCH 16/53 v2] perf tools: Fix mmap2 event allocation in synthesize
 code
References: <20160111210327.GG18367@kernel.org> <1452593524-138970-1-git-send-email-wangnan0@huawei.com> <50399556C9727B4D88A595C8584AAB3752692616@GSjpTKYDCembx32.service.hitachi.net>
In-Reply-To: <50399556C9727B4D88A595C8584AAB3752692616@GSjpTKYDCembx32.service.hitachi.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090205.5694DAB8.00DA,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 93d6b4697fe09ced1af799bb7218f93d
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/1/12 18:49, 平松雅巳 / HIRAMATU，MASAMI wrote:
>> From: Wang Nan [mailto:wangnan0@huawei.com]
>>
>> perf_event__synthesize_mmap_events() issues mmap2 events, but the
>> memory of that event is allocated using:
>>
>> mmap_event = malloc(sizeof(mmap_event->mmap) + machine->id_hdr_size);
>>
>> If path of mmap source file is long (near PATH_MAX), random crash
>> would happen. Should use sizeof(mmap_event->mmap2).
>>
>> Fix two memory allocations.
> Looks good to me. But hope to have another rename patch soon after this...

According to Arnaldo, we don't need rename patch. He think mmap_event
is okay. Right?

Thank you.