From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings Date: Tue, 12 Jan 2016 16:50:58 +0530 Message-ID: <5694E19A.2050107@nvidia.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Julia Lawall Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, k.kozlowski@samsung.com List-Id: linux-gpio@vger.kernel.org Hi Julia, Thanks for pointing this issue. What script do you run to get this error? I tried to run script/coccicheck and it did not showed this issue. When I run make with coccicheck per Documentation, it did not show specific to this error. Although, there was lots of output. I want to get this type of error by running script. Any command for this? Thanks, Laxman On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote: > Make sure (of/i2c/platform)_device_id tables are NULL terminated > > Generated by: scripts/coccinelle/misc/of_table.cocci > > CC: Laxman Dewangan > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- > > Please take the patch only if it's a positive warning. Thanks! > > rtc-max77xxx.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/rtc/rtc-max77xxx.c > +++ b/drivers/rtc/rtc-max77xxx.c > @@ -480,6 +480,7 @@ static const struct platform_device_id m > { .name = "max77xxx-rtc", }, > { .name = "max77620-rtc", }, > { .name = "max20024-rtc", }, > + {}, > }; > > static struct platform_driver max77xxx_rtc_driver = { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com. [216.228.121.65]) by gmr-mx.google.com with ESMTPS id jj4si12379951pac.2.2016.01.12.03.31.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jan 2016 03:31:16 -0800 (PST) Message-ID: <5694E19A.2050107@nvidia.com> Date: Tue, 12 Jan 2016 16:50:58 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Julia Lawall CC: , , , , , , , , , , , , , , , , , , Subject: [rtc-linux] Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi Julia, Thanks for pointing this issue. What script do you run to get this error? I tried to run script/coccicheck and it did not showed this issue. When I run make with coccicheck per Documentation, it did not show specific to this error. Although, there was lots of output. I want to get this type of error by running script. Any command for this? Thanks, Laxman On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote: > Make sure (of/i2c/platform)_device_id tables are NULL terminated > > Generated by: scripts/coccinelle/misc/of_table.cocci > > CC: Laxman Dewangan > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- > > Please take the patch only if it's a positive warning. Thanks! > > rtc-max77xxx.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/rtc/rtc-max77xxx.c > +++ b/drivers/rtc/rtc-max77xxx.c > @@ -480,6 +480,7 @@ static const struct platform_device_id m > { .name = "max77xxx-rtc", }, > { .name = "max77620-rtc", }, > { .name = "max20024-rtc", }, > + {}, > }; > > static struct platform_driver max77xxx_rtc_driver = { -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965212AbcALLbU (ORCPT ); Tue, 12 Jan 2016 06:31:20 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:5686 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933632AbcALLbQ (ORCPT ); Tue, 12 Jan 2016 06:31:16 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 12 Jan 2016 03:14:06 -0800 Message-ID: <5694E19A.2050107@nvidia.com> Date: Tue, 12 Jan 2016 16:50:58 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Julia Lawall CC: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings References: In-Reply-To: X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Julia, Thanks for pointing this issue. What script do you run to get this error? I tried to run script/coccicheck and it did not showed this issue. When I run make with coccicheck per Documentation, it did not show specific to this error. Although, there was lots of output. I want to get this type of error by running script. Any command for this? Thanks, Laxman On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote: > Make sure (of/i2c/platform)_device_id tables are NULL terminated > > Generated by: scripts/coccinelle/misc/of_table.cocci > > CC: Laxman Dewangan > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- > > Please take the patch only if it's a positive warning. Thanks! > > rtc-max77xxx.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/rtc/rtc-max77xxx.c > +++ b/drivers/rtc/rtc-max77xxx.c > @@ -480,6 +480,7 @@ static const struct platform_device_id m > { .name = "max77xxx-rtc", }, > { .name = "max77620-rtc", }, > { .name = "max20024-rtc", }, > + {}, > }; > > static struct platform_driver max77xxx_rtc_driver = {