From: Julien CORJON <corjon.j@ecagroup.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] qt/qt5base: force gstreamer on configure
Date: Tue, 12 Jan 2016 11:50:53 +0000 [thread overview]
Message-ID: <5694E89C.30807@ecagroup.com> (raw)
In-Reply-To: <20160110161902.GF3460@free.fr>
Yann, Peter, All
Le 10/01/2016 17:19, Yann E. MORIN a ?crit :
> Julien, All,
>
> On 2015-08-06 12:06 +0200, Julien Corjon spake thusly:
>> Fixes: http://autobuild.buildroot.net/results/0ee0f879e8563954c64b3940cdec39d2e6de937a/
>
> As Thomas said, this does not really fix that issue.
>
> However, still following Thomas comment, I think this is a valid patch,
Patch was valid back then.
> and it should be applied with a tweaked commit log;
>
> package/qt5base: add support for optional gstreamer
>
> qt5base can optionally support gstreamer-0.10 or gstreamer-1.0.
> Upstreamer still considers gstreamer-0.10 to be preferred over 1.0.
>
> Ensure that gstreamer, when enabled, is built before qt5base; tell
> qt5base to use the proper gstreamer variant, or none if gstreamer
> is not enabled.
>
> Signed-off-by: You
>
Peter already patch gstreamer for qt5base and he have removed
gstreamer0.1 support[1]. I'm not sure this was the good solution because
gstreamer0.1 is still the default choise for Qt[2] but no buildroot user
seems to complain about that.
> With that fixed, you can add my:
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Regards,
> Yann E. MORIN.
Regards,
Julien Corjon
[1]
https://git.busybox.net/buildroot/commit/?id=da9f034d5d1df10ad6c3e249a9a488dc7ef1c42a
[2] https://wiki.qt.io/New_Features_in_Qt_5.5
next prev parent reply other threads:[~2016-01-12 11:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 10:06 [Buildroot] [PATCH 1/2] qt/qt5base: force gstreamer on configure Julien Corjon
2015-08-06 10:06 ` [Buildroot] [PATCH 2/2] qt/qt5multimedia: install gsttools for gstreamer1 Julien Corjon
2015-08-06 11:30 ` [Buildroot] [PATCH 1/2] qt/qt5base: force gstreamer on configure Baruch Siach
2015-08-08 13:16 ` Thomas Petazzoni
2015-09-15 8:37 ` Will Wagner
2015-09-15 10:35 ` Julien CORJON
2016-01-10 16:19 ` Yann E. MORIN
2016-01-12 11:50 ` Julien CORJON [this message]
2016-01-12 12:24 ` Peter Korsgaard
2016-01-19 20:31 ` Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2015-08-06 11:35 Julien CORJON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5694E89C.30807@ecagroup.com \
--to=corjon.j@ecagroup.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.