From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Milo Kim <milo.kim@ti.com>
Cc: dmurphy@ti.com, linux-leds@vger.kernel.org
Subject: Re: [RFC] leds: lp8860: Support additional features
Date: Tue, 12 Jan 2016 16:20:29 +0100 [thread overview]
Message-ID: <569519BD.7010903@samsung.com> (raw)
In-Reply-To: <568CBD85.3040907@ti.com>
Hi Milo,
On 01/06/2016 08:08 AM, Milo Kim wrote:
> Hi Dan,
>
> I'm going to support additional features for LP8860 LED driver.
>
> * New functions
> - SPI support (only I2C is supported at this moment)
> - Brightness control by external PWM signal
> - Loading EEPROM value by using Linux firmware interface
> - Display mode support (currently, only cluster mode is supported)
>
> So, leds-lp8860 driver architecture will be changed as below.
>
> MFD: I2C/SPI operation, loading EEPROM values from firmware file
> Backlight: LP8860 display mode support
> LED: LP8860 cluster mode support
>
> * MFD (new)
> - Three files will be created.
> lp8860-core.c, lp8860-i2c.c and lp8860-spi.c
> - Firmware I/F
> Firmware binary file contains default EEPROM values.
> lp8860-core will request a firmware and write values via I2C/SPI.
> Bin files will be delivered in separate location later.
> This feature will support several EEPROM versions with single driver.
> - MFD devices
> lp8860-core will create MFD child devices based on EEPROM value.
> LED_STRING_CONF[2:0] bits will be read.
> mode 0: backlight
> 1: backlight + LED
> 2: backlight + LED 1, 2
> 3: backlight + LED 1, 2, 3
> 4: backlight 1, 2
> 5: backlight
> 6: backlight + LED 1, 2
> 7: LED 1,2,3,4
> (Please refer to the page 28 and 29 of LP8860 datasheet.
> http://www.ti.com/lit/ds/symlink/lp8860-q1.pdf)
>
> * Backlight (new)
> - PWM control mode support
> - Register backlight device
>
> * LED (will be modified)
> - Unlock/lock EEPROM code will be moved to lp8860-core part
> - Multiple LED output channels will be supported
>
> I'd like to have your opinion prior to creating patches.
>
> Jacek,
> It would be best if you have better idea for this. Thanks!
I'll wait for the first version of the patch. You haven't provided
any info on how you want to add the support for multiple channels,
so there is nothing I can refer to.
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2016-01-12 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 7:08 [RFC] leds: lp8860: Support additional features Milo Kim
2016-01-08 16:47 ` Dan Murphy
2016-01-08 18:33 ` Dan Murphy
2016-01-11 0:21 ` Milo Kim
2016-01-12 15:20 ` Jacek Anaszewski [this message]
2016-01-12 23:18 ` Milo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569519BD.7010903@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=dmurphy@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=milo.kim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.