From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milo Kim Subject: Re: [RFC] leds: lp8860: Support additional features Date: Wed, 13 Jan 2016 08:18:35 +0900 Message-ID: <569589CB.6040204@ti.com> References: <568CBD85.3040907@ti.com> <569519BD.7010903@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:57336 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752995AbcALXSn (ORCPT ); Tue, 12 Jan 2016 18:18:43 -0500 In-Reply-To: <569519BD.7010903@samsung.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Jacek Anaszewski Cc: dmurphy@ti.com, linux-leds@vger.kernel.org Hi Jacek, On 01/13/2016 12:20 AM, Jacek Anaszewski wrote: > Hi Milo, > > On 01/06/2016 08:08 AM, Milo Kim wrote: >> Hi Dan, >> >> I'm going to support additional features for LP8860 LED driver. >> >> * New functions >> - SPI support (only I2C is supported at this moment) >> - Brightness control by external PWM signal >> - Loading EEPROM value by using Linux firmware interface >> - Display mode support (currently, only cluster mode is supported) >> >> So, leds-lp8860 driver architecture will be changed as below. >> >> MFD: I2C/SPI operation, loading EEPROM values from firmware file >> Backlight: LP8860 display mode support >> LED: LP8860 cluster mode support >> >> * MFD (new) >> - Three files will be created. >> lp8860-core.c, lp8860-i2c.c and lp8860-spi.c >> - Firmware I/F >> Firmware binary file contains default EEPROM values. >> lp8860-core will request a firmware and write values via I2C/SPI. >> Bin files will be delivered in separate location later. >> This feature will support several EEPROM versions with single >> driver. >> - MFD devices >> lp8860-core will create MFD child devices based on EEPROM value. >> LED_STRING_CONF[2:0] bits will be read. >> mode 0: backlight >> 1: backlight + LED >> 2: backlight + LED 1, 2 >> 3: backlight + LED 1, 2, 3 >> 4: backlight 1, 2 >> 5: backlight >> 6: backlight + LED 1, 2 >> 7: LED 1,2,3,4 >> (Please refer to the page 28 and 29 of LP8860 datasheet. >> http://www.ti.com/lit/ds/symlink/lp8860-q1.pdf) >> >> * Backlight (new) >> - PWM control mode support >> - Register backlight device >> >> * LED (will be modified) >> - Unlock/lock EEPROM code will be moved to lp8860-core part >> - Multiple LED output channels will be supported >> >> I'd like to have your opinion prior to creating patches. >> >> Jacek, >> It would be best if you have better idea for this. Thanks! > > I'll wait for the first version of the patch. You haven't provided > any info on how you want to add the support for multiple channels, > so there is nothing I can refer to. OK, thanks. Multiple channel configuration can be done through the device tree or by reading the firmware. I'm considering the DT properties. I'll submit the patches in few weeks. Best regards, Milo