From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v2 7/7] virtio: add 1.0 support
Date: Wed, 13 Jan 2016 12:31:43 +0900
Message-ID: <5695C51F.80107@igel.co.jp>
References: <1449719650-3482-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1452581944-24838-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1452581944-24838-8-git-send-email-yuanhan.liu@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Cc: "Michael S. Tsirkin" <mst@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 395B18E5D
 for <dev@dpdk.org>; Wed, 13 Jan 2016 04:31:47 +0100 (CET)
Received: by mail-pa0-f42.google.com with SMTP id ho8so89708772pac.2
 for <dev@dpdk.org>; Tue, 12 Jan 2016 19:31:47 -0800 (PST)
In-Reply-To: <1452581944-24838-8-git-send-email-yuanhan.liu@linux.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2016/01/12 15:59, Yuanhan Liu wrote:
> +static int
> +virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)
> +{
> +	uint8_t pos;
> +	struct virtio_pci_cap cap;
> +	int ret;
> +
> +	if (rte_eal_pci_map_device(dev) < 0) {
> +		PMD_INIT_LOG(DEBUG, "failed to map pci device!");
> +		return -1;
> +	}
> +

Do you need to call rte_eal_pci_unmap_device() in somewhere in this file?

Anyway, I've reviewed and tested your all patches.
And it seems except for it, I guess your patches are good.

Thanks,
Tetsuya