From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx series RTC IP Date: Wed, 13 Jan 2016 09:55:19 +0530 Message-ID: <5695D1AF.9000806@nvidia.com> References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-6-git-send-email-ldewangan@nvidia.com> <569594F0.4020007@samsung.com> <5695CD73.5010709@nvidia.com> <5695D268.3060705@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5695D268.3060705@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com Cc: lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com List-Id: linux-gpio@vger.kernel.org On Wednesday 13 January 2016 09:58 AM, Krzysztof Kozlowski wrote: > On 13.01.2016 13:07, Laxman Dewangan wrote: >> On Wednesday 13 January 2016 05:36 AM, Krzysztof Kozlowski wrote: > >> That is also fine to me but still I am not comfortable with the config >> name and driver file name as this does not suggest the common. > The name does not matter. Really. We have a lot of drivers with a > specific device-like name and supporting different devices. To point > that your argument is invalid - your initial name of driver > "rtc-max77620.c" supported totally different "names": the max77620 and > max20024. It also wasn't suggesting something "common"... In all config string, I have mentioned the MAX20024. > With my approach we are not developing common think neither. We just > want to extend/re-use existing max77686 (or max77802) driver for new > devices. Just like everywhere else. OK, fine to me if this is acceptable. I will drop this rtc patch form this series and work in max77686 driver to modify first and once merged, use this config on my defconfig. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com. [216.228.121.143]) by gmr-mx.google.com with ESMTPS id dz2si7655340pab.1.2016.01.12.20.35.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jan 2016 20:35:39 -0800 (PST) Message-ID: <5695D1AF.9000806@nvidia.com> Date: Wed, 13 Jan 2016 09:55:19 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Krzysztof Kozlowski , , , , , , , , , , , CC: , , , , , , Subject: [rtc-linux] Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx series RTC IP References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-6-git-send-email-ldewangan@nvidia.com> <569594F0.4020007@samsung.com> <5695CD73.5010709@nvidia.com> <5695D268.3060705@samsung.com> In-Reply-To: <5695D268.3060705@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Wednesday 13 January 2016 09:58 AM, Krzysztof Kozlowski wrote: > On 13.01.2016 13:07, Laxman Dewangan wrote: >> On Wednesday 13 January 2016 05:36 AM, Krzysztof Kozlowski wrote: > >> That is also fine to me but still I am not comfortable with the config >> name and driver file name as this does not suggest the common. > The name does not matter. Really. We have a lot of drivers with a > specific device-like name and supporting different devices. To point > that your argument is invalid - your initial name of driver > "rtc-max77620.c" supported totally different "names": the max77620 and > max20024. It also wasn't suggesting something "common"... In all config string, I have mentioned the MAX20024. > With my approach we are not developing common think neither. We just > want to extend/re-use existing max77686 (or max77802) driver for new > devices. Just like everywhere else. OK, fine to me if this is acceptable. I will drop this rtc patch form this series and work in max77686 driver to modify first and once merged, use this config on my defconfig. -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754701AbcAMEfl (ORCPT ); Tue, 12 Jan 2016 23:35:41 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:4409 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754103AbcAMEfj (ORCPT ); Tue, 12 Jan 2016 23:35:39 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 12 Jan 2016 20:18:25 -0800 Message-ID: <5695D1AF.9000806@nvidia.com> Date: Wed, 13 Jan 2016 09:55:19 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , , , , , , , , , , , CC: , , , , , , Subject: Re: [PATCH V2 5/6] rtc: max77xxx: add RTC driver for Maxim MAX77xxx series RTC IP References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-6-git-send-email-ldewangan@nvidia.com> <569594F0.4020007@samsung.com> <5695CD73.5010709@nvidia.com> <5695D268.3060705@samsung.com> In-Reply-To: <5695D268.3060705@samsung.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 13 January 2016 09:58 AM, Krzysztof Kozlowski wrote: > On 13.01.2016 13:07, Laxman Dewangan wrote: >> On Wednesday 13 January 2016 05:36 AM, Krzysztof Kozlowski wrote: > >> That is also fine to me but still I am not comfortable with the config >> name and driver file name as this does not suggest the common. > The name does not matter. Really. We have a lot of drivers with a > specific device-like name and supporting different devices. To point > that your argument is invalid - your initial name of driver > "rtc-max77620.c" supported totally different "names": the max77620 and > max20024. It also wasn't suggesting something "common"... In all config string, I have mentioned the MAX20024. > With my approach we are not developing common think neither. We just > want to extend/re-use existing max77686 (or max77802) driver for new > devices. Just like everywhere else. OK, fine to me if this is acceptable. I will drop this rtc patch form this series and work in max77686 driver to modify first and once merged, use this config on my defconfig.