From: "Wangnan (F)" <wangnan0@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, "Ingo Molnar" <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable
Date: Wed, 13 Jan 2016 17:46:13 +0800 [thread overview]
Message-ID: <56961CE5.8090802@huawei.com> (raw)
In-Reply-To: <20160113091913.GA4487@krava.brq.redhat.com>
On 2016/1/13 17:19, Jiri Olsa wrote:
> On Tue, Jan 12, 2016 at 05:28:28PM +0800, Wangnan (F) wrote:
>
> SNIP
>
>> For example:
>>
>> $ make feature-dump LDFLAGS="-static"
>> BUILD: Doing 'make -j24' parallel build
>>
>> Auto-detecting system features:
>> <SNIP>
>> ... zlib: [ on ]
>> ... lzma: [ OFF ] <--- looks good. I don't have
>> static lzma library
>> ... get_cpuid: [ on ]
>> ... bpf: [ on ]
>>
>>
>> $ make feature-dump
>> BUILD: Doing 'make -j24' parallel build
>>
>> Auto-detecting system features:
>> <SNIP>
>> ... zlib: [ on ]
>> ... lzma: [ on ] <--- also good
>> ... get_cpuid: [ on ]
>> ... bpf: [ on ]
>>
>>
>> $ make feature-dump LDFLAGS="-static"
>> BUILD: Doing 'make -j24' parallel build
>>
>> Auto-detecting system features:
>> <SNIP>
>> ... zlib: [ on ]
>> ... lzma: [ on ] <--- Bad...
>> ... get_cpuid: [ on ]
>> ... bpf: [ on ]
>>
>> Thank you.
> right, it's because feature is not under build framework and
> compilation does not care about flags change..
>
> I'll try to check on that.. does this patch help to improve
> the current speed or do you need to solve this to get substantial
> speedup?
I'm working on it. I have already done it, but still have some
problem. On some machine 'make_static' test target lost
'-liberty -lz' in its linker options. Seems something wrong in
this part:
ifeq ($(feature-libbfd), 1)
EXTLIBS += -lbfd
# call all detections now so we get correct
# status in VF output
$(call feature_check,liberty)
$(call feature_check,liberty-z)
$(call feature_check,cplus-demangle)
ifeq ($(feature-liberty), 1)
EXTLIBS += -liberty
else
ifeq ($(feature-liberty-z), 1)
EXTLIBS += -liberty -lz
endif
endif
endif
On a 24 core machine the build-test takes about 16 mins. Faster than before:
real 16m7.642s
user 171m47.488s
sys 19m10.692s
next prev parent reply other threads:[~2016-01-13 9:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 10:54 [PATCH 0/6] tools: Add clean targets for tools directory Jiri Olsa
2016-01-11 10:54 ` [PATCH 1/6] " Jiri Olsa
2016-01-12 10:06 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2016-01-11 10:54 ` [PATCH 2/6] tools bpf: Add *.cmd files clean up Jiri Olsa
2016-01-12 10:07 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2016-01-11 10:54 ` [PATCH 3/6] tools lockdep: " Jiri Olsa
2016-01-12 10:07 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2016-01-11 10:54 ` [PATCH 4/6] perf tools: Add missing sources in perf's MANIFEST Jiri Olsa
2016-01-12 10:07 ` [tip:perf/urgent] perf tools: Add missing sources to perf' s MANIFEST tip-bot for Jiri Olsa
2016-01-11 10:54 ` [RFC 5/6] perf build: Add feature-dump target Jiri Olsa
2016-01-11 10:54 ` [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable Jiri Olsa
2016-01-12 9:28 ` Wangnan (F)
2016-01-13 9:19 ` Jiri Olsa
2016-01-13 9:46 ` Wangnan (F) [this message]
2016-01-13 10:03 ` Jiri Olsa
2016-01-13 10:11 ` Wangnan (F)
2016-01-13 12:02 ` Wangnan (F)
2016-01-13 12:15 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56961CE5.8090802@huawei.com \
--to=wangnan0@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.