From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756571AbcAMKLq (ORCPT ); Wed, 13 Jan 2016 05:11:46 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:17122 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755305AbcAMKLj (ORCPT ); Wed, 13 Jan 2016 05:11:39 -0500 Message-ID: <569622CB.50903@huawei.com> Date: Wed, 13 Jan 2016 18:11:23 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jiri Olsa CC: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , David Ahern , "Ingo Molnar" , Namhyung Kim , Peter Zijlstra Subject: Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable References: <1452509693-13452-1-git-send-email-jolsa@kernel.org> <1452509693-13452-7-git-send-email-jolsa@kernel.org> <5694C73C.3070007@huawei.com> <20160113091913.GA4487@krava.brq.redhat.com> <56961CE5.8090802@huawei.com> <20160113100328.GA5515@krava.brq.redhat.com> In-Reply-To: <20160113100328.GA5515@krava.brq.redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.569622CA.0066,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 52c79e33011bb9305966993c5404229a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/13 18:03, Jiri Olsa wrote: > On Wed, Jan 13, 2016 at 05:46:13PM +0800, Wangnan (F) wrote: > > SNIP > >>> I'll try to check on that.. does this patch help to improve >>> the current speed or do you need to solve this to get substantial >>> speedup? >> I'm working on it. I have already done it, but still have some >> problem. On some machine 'make_static' test target lost >> '-liberty -lz' in its linker options. Seems something wrong in >> this part: >> >> ifeq ($(feature-libbfd), 1) >> EXTLIBS += -lbfd >> >> # call all detections now so we get correct >> # status in VF output >> $(call feature_check,liberty) >> $(call feature_check,liberty-z) >> $(call feature_check,cplus-demangle) >> >> ifeq ($(feature-liberty), 1) >> EXTLIBS += -liberty >> else >> ifeq ($(feature-liberty-z), 1) >> EXTLIBS += -liberty -lz >> endif >> endif >> endif > IIRC we had issues with this before.. different systems > provide those libs in different way, like: > 2cf9040714f3 perf tools: Fix bfd dependency libraries detection > > you might want to check feature detection code if it gets > built properly on your system No this problem. There's no feature-libiberty and feature-libiberty-z in output feature-dump file. This is the key reason. > jirka