From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp115.iad3a.emailsrvr.com ([173.203.187.115]:47608 "EHLO smtp115.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932395AbcAMKhR (ORCPT ); Wed, 13 Jan 2016 05:37:17 -0500 Subject: Re: [PATCH v2] staging: comedi: ni_tiocmd: change mistaken use of start_src for start_arg To: "Spencer E. Olson" , devel@driverdev.osuosl.org References: <56951A9A.8060409@mev.co.uk> <1452619998-14586-1-git-send-email-olsonse@umich.edu> Cc: H Hartley Sweeten , Greg Kroah-Hartman , stable@vger.kernel.org From: Ian Abbott Message-ID: <569628DB.8070105@mev.co.uk> Date: Wed, 13 Jan 2016 10:37:15 +0000 MIME-Version: 1.0 In-Reply-To: <1452619998-14586-1-git-send-email-olsonse@umich.edu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 12/01/16 17:33, Spencer E. Olson wrote: > This fixes a bug in function ni_tio_input_inttrig(). The trigger number > should be compared to cmd->start_arg, not cmd->start_src. > > Fixes: 6a760394d7eb ("staging: comedi: ni_tiocmd: clarify the > cmd->start_arg validation and use") > Cc: # 3.17+ > Signed-off-by: Spencer E. Olson > --- > Added description suggested by Ian and Dan. Added Fixes:, CC: tags as > suggested by Ian. > > drivers/staging/comedi/drivers/ni_tiocmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c > index 437f723..823e479 100644 > --- a/drivers/staging/comedi/drivers/ni_tiocmd.c > +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c > @@ -92,7 +92,7 @@ static int ni_tio_input_inttrig(struct comedi_device *dev, > unsigned long flags; > int ret = 0; > > - if (trig_num != cmd->start_src) > + if (trig_num != cmd->start_arg) > return -EINVAL; > > spin_lock_irqsave(&counter->lock, flags); > Thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-