From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024 Date: Wed, 13 Jan 2016 18:41:11 +0530 Message-ID: <56964CEF.3030900@nvidia.com> References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-7-git-send-email-ldewangan@nvidia.com> <5695A854.60108@samsung.com> <5696378B.6070704@nvidia.com> <20160113115736.GJ6588@sirena.org.uk> <56963D8D.9060908@nvidia.com> <20160113123133.GK6588@sirena.org.uk> <5696451F.3000707@nvidia.com> <20160113130909.GL6588@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160113130909.GL6588@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Krzysztof Kozlowski , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, Mallikarjun Kasoju List-Id: linux-gpio@vger.kernel.org On Wednesday 13 January 2016 06:39 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Wed, Jan 13, 2016 at 06:07:51PM +0530, Laxman Dewangan wrote: >> On Wednesday 13 January 2016 06:01 PM, Mark Brown wrote: >>> What is FPS_SRC and why is it set from init_data? A driver should never >>> be looking at init_data. >> When FPS_SRC is set to NONE (this is needed from platform data) then based >> on constraint like boot enable/always enable, it need to be on desired >> state. Otherwise we may endup with disabling the rail when setting to NONE >> and create issue. > What is "it" and why can't we check what the current configuration is > while setting FPS to NONE? I will have platform specific data in callback of enable/disable only. Which call back do I need to set this? enable/disable or post register? >> I need to set the FPS src properly for each rails before callback happen >> from regulator init so that enable/disable/is_enable can handle it properly. > Why not just reorder the callback so it happens before the constraints > are applied? > which callback I need to reorder for getting the context for configruation? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com. [216.228.121.64]) by gmr-mx.google.com with ESMTPS id 190si135163pfb.1.2016.01.13.05.21.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jan 2016 05:21:32 -0800 (PST) Message-ID: <56964CEF.3030900@nvidia.com> Date: Wed, 13 Jan 2016 18:41:11 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Mark Brown CC: Krzysztof Kozlowski , , , , , , , , , , , , , , , , , , Mallikarjun Kasoju Subject: [rtc-linux] Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024 References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-7-git-send-email-ldewangan@nvidia.com> <5695A854.60108@samsung.com> <5696378B.6070704@nvidia.com> <20160113115736.GJ6588@sirena.org.uk> <56963D8D.9060908@nvidia.com> <20160113123133.GK6588@sirena.org.uk> <5696451F.3000707@nvidia.com> <20160113130909.GL6588@sirena.org.uk> In-Reply-To: <20160113130909.GL6588@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Wednesday 13 January 2016 06:39 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Wed, Jan 13, 2016 at 06:07:51PM +0530, Laxman Dewangan wrote: >> On Wednesday 13 January 2016 06:01 PM, Mark Brown wrote: >>> What is FPS_SRC and why is it set from init_data? A driver should never >>> be looking at init_data. >> When FPS_SRC is set to NONE (this is needed from platform data) then based >> on constraint like boot enable/always enable, it need to be on desired >> state. Otherwise we may endup with disabling the rail when setting to NONE >> and create issue. > What is "it" and why can't we check what the current configuration is > while setting FPS to NONE? I will have platform specific data in callback of enable/disable only. Which call back do I need to set this? enable/disable or post register? >> I need to set the FPS src properly for each rails before callback happen >> from regulator init so that enable/disable/is_enable can handle it properly. > Why not just reorder the callback so it happens before the constraints > are applied? > which callback I need to reorder for getting the context for configruation? -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760083AbcAMN2t (ORCPT ); Wed, 13 Jan 2016 08:28:49 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:2353 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754707AbcAMNVc (ORCPT ); Wed, 13 Jan 2016 08:21:32 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 13 Jan 2016 05:17:02 -0800 Message-ID: <56964CEF.3030900@nvidia.com> Date: Wed, 13 Jan 2016 18:41:11 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Mark Brown CC: Krzysztof Kozlowski , , , , , , , , , , , , , , , , , , Mallikarjun Kasoju Subject: Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024 References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-7-git-send-email-ldewangan@nvidia.com> <5695A854.60108@samsung.com> <5696378B.6070704@nvidia.com> <20160113115736.GJ6588@sirena.org.uk> <56963D8D.9060908@nvidia.com> <20160113123133.GK6588@sirena.org.uk> <5696451F.3000707@nvidia.com> <20160113130909.GL6588@sirena.org.uk> In-Reply-To: <20160113130909.GL6588@sirena.org.uk> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 13 January 2016 06:39 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Wed, Jan 13, 2016 at 06:07:51PM +0530, Laxman Dewangan wrote: >> On Wednesday 13 January 2016 06:01 PM, Mark Brown wrote: >>> What is FPS_SRC and why is it set from init_data? A driver should never >>> be looking at init_data. >> When FPS_SRC is set to NONE (this is needed from platform data) then based >> on constraint like boot enable/always enable, it need to be on desired >> state. Otherwise we may endup with disabling the rail when setting to NONE >> and create issue. > What is "it" and why can't we check what the current configuration is > while setting FPS to NONE? I will have platform specific data in callback of enable/disable only. Which call back do I need to set this? enable/disable or post register? >> I need to set the FPS src properly for each rails before callback happen >> from regulator init so that enable/disable/is_enable can handle it properly. > Why not just reorder the callback so it happens before the constraints > are applied? > which callback I need to reorder for getting the context for configruation?