From: John Harrison <John.C.Harrison@Intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-GFX@Lists.FreeDesktop.Org
Subject: Re: [PATCH] drm/i915: Fix for reserved space WARN_ON when ring begin fails
Date: Wed, 13 Jan 2016 13:48:50 +0000 [thread overview]
Message-ID: <569655C2.5020201@Intel.com> (raw)
In-Reply-To: <20160113130904.GC3541@nuc-i3427.alporthouse.com>
On 13/01/2016 13:09, Chris Wilson wrote:
> On Wed, Jan 13, 2016 at 12:52:40PM +0000, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> The reserved space code was not cleaning up properly in the case where
>> the intel_ring_begin() call failed. This led to WARN_ONs firing about
>> a double reserve call when running the gem_reset_stats IGT test.
> *reserve_space() failure leads to a i915_gem_request_cancel() which
> calls intel_ring_reserved_space_cancel().
> -Chris
>
Hmm, this is very true. Evidently something weird is going on in my
tree. Ignore this patch!
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-13 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 12:52 [PATCH] drm/i915: Fix for reserved space WARN_ON when ring begin fails John.C.Harrison
2016-01-13 13:09 ` Chris Wilson
2016-01-13 13:48 ` John Harrison [this message]
2016-01-13 13:49 ` ✗ failure: Fi.CI.BAT Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569655C2.5020201@Intel.com \
--to=john.c.harrison@intel.com \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.