From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Wed, 13 Jan 2016 13:57:28 +0000 Subject: Re: [lm-sensors] [PATCH v2] hwmon: Add LTC2990 sensor driver Message-Id: <569657C8.6070607@roeck-us.net> List-Id: References: <568FD131.4080308@roeck-us.net> <1452067627-24939-1-git-send-email-mike.looijmans@topic.nl> <1452683150-27747-1-git-send-email-mike.looijmans@topic.nl> <5696500E.4090905@roeck-us.net> <56965661.2010307@topic.nl> In-Reply-To: <56965661.2010307@topic.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mike Looijmans , lm-sensors@lm-sensors.org Cc: jdelvare@suse.com, linux-kernel@vger.kernel.org On 01/13/2016 05:51 AM, Mike Looijmans wrote: > On 13-01-16 14:24, Guenter Roeck wrote: >> On 01/13/2016 03:05 AM, Mike Looijmans wrote: >>> This adds support for the Linear Technology LTC2990 I2C System Monitor. >>> The LTC2990 supports a combination of voltage, current and temperature >>> monitoring. This driver currently only supports reading two currents >>> by measuring two differential voltages across series resistors, in >>> addition to the Vcc supply voltage and internal temperature. >>> >>> This is sufficient to support the Topic Miami SOM which uses this chip >>> to monitor the currents flowing into the FPGA and the CPU parts. >>> >>> Signed-off-by: Mike Looijmans >> >> Mike, >> >> That looks much better. Can you send me the output of i2cdump for the chip ? >> That would help me writing module test code for it. > > I'm kinda interested into how that would work. > https://github.com/groeck/module-tests > I'll have to remove the driver first to get i2cdump to work on the chip. I cannot force a device removal from user space while running, can I? > And i suppose you want a dump of a chip in running status? (On boot, all are registers are simply set to zero) > Just use i2cdump -f while the driver is active. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759068AbcAMN5j (ORCPT ); Wed, 13 Jan 2016 08:57:39 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:56292 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753484AbcAMN5h (ORCPT ); Wed, 13 Jan 2016 08:57:37 -0500 Subject: Re: [PATCH v2] hwmon: Add LTC2990 sensor driver To: Mike Looijmans , lm-sensors@lm-sensors.org References: <568FD131.4080308@roeck-us.net> <1452067627-24939-1-git-send-email-mike.looijmans@topic.nl> <1452683150-27747-1-git-send-email-mike.looijmans@topic.nl> <5696500E.4090905@roeck-us.net> <56965661.2010307@topic.nl> Cc: jdelvare@suse.com, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <569657C8.6070607@roeck-us.net> Date: Wed, 13 Jan 2016 05:57:28 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56965661.2010307@topic.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/13/2016 05:51 AM, Mike Looijmans wrote: > On 13-01-16 14:24, Guenter Roeck wrote: >> On 01/13/2016 03:05 AM, Mike Looijmans wrote: >>> This adds support for the Linear Technology LTC2990 I2C System Monitor. >>> The LTC2990 supports a combination of voltage, current and temperature >>> monitoring. This driver currently only supports reading two currents >>> by measuring two differential voltages across series resistors, in >>> addition to the Vcc supply voltage and internal temperature. >>> >>> This is sufficient to support the Topic Miami SOM which uses this chip >>> to monitor the currents flowing into the FPGA and the CPU parts. >>> >>> Signed-off-by: Mike Looijmans >> >> Mike, >> >> That looks much better. Can you send me the output of i2cdump for the chip ? >> That would help me writing module test code for it. > > I'm kinda interested into how that would work. > https://github.com/groeck/module-tests > I'll have to remove the driver first to get i2cdump to work on the chip. I cannot force a device removal from user space while running, can I? > And i suppose you want a dump of a chip in running status? (On boot, all are registers are simply set to zero) > Just use i2cdump -f while the driver is active. Thanks, Guenter