From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86emul: support clzero Date: Wed, 13 Jan 2016 15:10:59 +0000 Message-ID: <56966903.8030209@citrix.com> References: <56016E8102000078000A45B7@prv-mh.provo.novell.com> <5693D066.6070607@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aJN4i-000261-2t for xen-devel@lists.xenproject.org; Wed, 13 Jan 2016 15:11:04 +0000 In-Reply-To: <5693D066.6070607@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Aravind Gopalakrishnan , Jan Beulich , xen-devel Cc: Keir Fraser , suravee.suthikulpanit@amd.com List-Id: xen-devel@lists.xenproject.org On 11/01/16 15:55, Aravind Gopalakrishnan wrote: > On 9/22/2015 8:06 AM, Jan Beulich wrote: >> ... in anticipation of this possibly going to get used by guests for >> basic thinks like memset() or clearing or pages. >> >> Since the emulation doesn't use clzero itself, checking the guest's >> CPUID for the feature to be exposed is (intentionally) being avoided >> here. All that's required is sensible guest side data for the clflush >> line size. >> >> Signed-off-by: Jan Beulich >> >> > > Reviewed-by: Aravind Gopalakrishnan Acked-by: Andrew Cooper I would still like to see some instruction documentation as the soonest possible opportunity, to give the implementation an independent review. ~Andrew