From: "Andrew F. Davis" <afd@ti.com>
To: Liu Xiang <liu.xiang6@zte.com.cn>, linux-pm@vger.kernel.org
Cc: pali.rohar@gmail.com, sre@kernel.org, dbaryshkov@gmail.com,
dwmw2@infradead.org
Subject: Re: [PATCH v4] power: bq27xxx_battery: Fix bq27541 AveragePower register address
Date: Wed, 13 Jan 2016 09:16:17 -0600 [thread overview]
Message-ID: <56966A41.3060809@ti.com> (raw)
In-Reply-To: <1452348639-3072-1-git-send-email-liu.xiang6@zte.com.cn>
On 01/09/2016 08:10 AM, Liu Xiang wrote:
> Currently in bq27541 driver, the average power register address is
> incorrectly set to 0x76, which would result in an error:
> bq27xxx-battery 2-0055: error reading average power register 10: -11
> According to the bq27541 datasheet, fix this problem by setting
> the average power register address to 0x24.
>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
> ---
> v4:
> - Modify the patch format.
> ---
> drivers/power/bq27xxx_battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
> index 880233c..633f96d 100644
> --- a/drivers/power/bq27xxx_battery.c
> +++ b/drivers/power/bq27xxx_battery.c
> @@ -242,7 +242,7 @@ static u8 bq27541_regs[] = {
> INVALID_REG_ADDR, /* AE - NA */
> 0x2c, /* SOC(RSOC) */
> 0x3c, /* DCAP */
> - 0x76, /* AP */
> + 0x24, /* AP */
> };
>
> static u8 bq27545_regs[] = {
>
Acked-by: Andrew F. Davis <afd@ti.com>
next prev parent reply other threads:[~2016-01-13 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 14:10 [PATCH v4] power: bq27xxx_battery: Fix bq27541 AveragePower register address Liu Xiang
2016-01-13 15:16 ` Andrew F. Davis [this message]
2016-01-15 2:13 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56966A41.3060809@ti.com \
--to=afd@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=liu.xiang6@zte.com.cn \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.