From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <jgross@suse.com>
Subject: Re: A couple of HVMlite loose ends
Date: Wed, 13 Jan 2016 17:05:24 +0100
Message-ID: <569675C4.6060605@suse.com>
References: <569671EC.7010101@citrix.com> <56967391.1080300@suse.com>
	<569674E9.5030702@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <jgross@suse.com>) id 1aJNvL-0005cl-Hd
	for xen-devel@lists.xenproject.org; Wed, 13 Jan 2016 16:05:27 +0000
In-Reply-To: <569674E9.5030702@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, David Vrabel <david.vrabel@citrix.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 13/01/16 17:01, Roger Pau Monn=E9 wrote:
> El 13/01/16 a les 16.56, Juergen Gross ha escrit:
>> On 13/01/16 16:49, Roger Pau Monn=E9 wrote:
>>>  b) Setting up the initial MTRR state from libxl/libxc for HVMlite DomU
>>> and from the Xen domain builder for HVMlite Dom0. This again implies
>>> some functional duplication of MTRR related code, since now we would
>>> have 3 different places where MTRR is setup. One inside hvmloader for
>>> classic HVM guests, another one inside of libxl/libxc for HVMlite DomU
>>> and yet another one in the Dom0 building for HVMlite Dom0.
> =

> Moving the code to xen/common/lib<blah> is not suitable in this case (or
> so I think), because hvmloader runs inside of the guest (just like a
> regular BIOS firmware), while we would need to do this from the outside
> for HVMlite guests (using mtrr_def_type_msr_set, mtrr_fix_range_msr_set
> and mtrr_var_range_msr_set).

Have a look how xen/common/libelf is being used from libxc and the
hypervisor. It is just code included via make instead of duplicating it
on source level.


Juergen