From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJOOM-0007aM-Fg for qemu-devel@nongnu.org; Wed, 13 Jan 2016 11:35:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJOOL-0001GU-GZ for qemu-devel@nongnu.org; Wed, 13 Jan 2016 11:35:26 -0500 References: <1450802786-20893-1-git-send-email-kwolf@redhat.com> <1450802786-20893-6-git-send-email-kwolf@redhat.com> <5679B5DE.5070205@redhat.com> <568C25CB.7050808@redhat.com> <20160113142545.GB4356@noname.redhat.com> From: Eric Blake Message-ID: <56967CC6.7050104@redhat.com> Date: Wed, 13 Jan 2016 09:35:18 -0700 MIME-Version: 1.0 In-Reply-To: <20160113142545.GB4356@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i1EcntGR4sMv7M1wqqMxRVKEg4GE8OcJa" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 05/10] block: Inactivate BDS when migration completes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , John Snow Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --i1EcntGR4sMv7M1wqqMxRVKEg4GE8OcJa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/13/2016 07:25 AM, Kevin Wolf wrote: >>> The name BDRV_O_INCOMING now doesn't quite match semantics on the >>> source, but I don't have any better suggestions. BDRV_O_LIMITED_USE?= >>> BDRV_O_HANDOFF? At any rate, I fully agree with your logic of lockin= g >>> things down on the source to mark that the destination is about to ta= ke >>> over write access to the file. >>> >> >> INCOMING is handy as it keeps the code simple, even if it's weird to >> read. Is it worth adding the extra ifs/case statements everywhere to a= dd >> in BDRV_O_HANDOFF? Maybe in the future someone will use BDRV_O_INCOMIN= G >> to mean something more specific (data is incoming, not just in the >> process of being handed off) that could cause problems. >> >> Maybe even just renaming BDRV_O_INCOMING right now to be BDRV_O_HANDOF= F >> would accomplish the semantics we want on both source and destination >> without needing two flags. >> >> Follow your dreams, Go with what you feel. >=20 > How about renaming BDRV_O_INCOMING to BDRV_O_INACTIVE? BDRV_O_INACTIVE works for me. Do the rename as a separate mechanical patch, obviously. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --i1EcntGR4sMv7M1wqqMxRVKEg4GE8OcJa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWlnzGAAoJEKeha0olJ0Nq9OcH/3+gjCcZRKmHTmpzf9IB0koP ++CD5AGfjFDGfiXbVRyQsUgwL9F+qZs2huhwoXBxSA2QaZA1nMdoFythSxthTbY1 xIDLa6v+AVM1ti/6/p8JUN6SG6cxrHC9166xzzg8O1YF0uOyG6PAh6ZiqrInxfGT PtbqsiWy0zryCDEnGFj5yZp4YNc+4ToAJ7PuzV2FS+BhhDVyCzen23jy6PIhf60Y Zj3od4tJlbKVTe+x1uDQKxSL8EvrwAIau0hcu25u0WP+ixSfrnAKL/aF835F4POZ b62R4zcVZc+xGKEl0ZKJNXJeTykzGqi2tN5TR9NzJXm9X3M0ZQ/1opvOnvtxq+4= =Qvhy -----END PGP SIGNATURE----- --i1EcntGR4sMv7M1wqqMxRVKEg4GE8OcJa--