From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH v4 05/11] of: earlycon: Initialize port fields from DT properties Date: Wed, 13 Jan 2016 08:35:40 -0800 Message-ID: <56967CDC.6040706@hurleysoftware.com> References: <1428515119-25248-1-git-send-email-peter@hurleysoftware.com> <1452627672-9482-1-git-send-email-peter@hurleysoftware.com> <1452627672-9482-6-git-send-email-peter@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Greg Kroah-Hartman , Masahiro Yamada , Grant Likely , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kevin Cernekee , Jon Hunter , Sebastian Frias , Paul Burton List-Id: linux-serial@vger.kernel.org On 01/12/2016 03:49 PM, Rob Herring wrote: > On Tue, Jan 12, 2016 at 1:41 PM, Peter Hurley wrote: >> Read the optional "reg-offset", "reg-shift", "reg-io-width" and endianness >> properties and initialize the respective struct uart_port field if found. >> >> NB: These bindings are common to several drivers and the values merely >> indicate the default value; the registering earlycon setup() method can >> simply override the values if required. >> >> Signed-off-by: Peter Hurley >> --- > >> diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c >> index 7509ee34d..03eac4a 100644 >> --- a/drivers/tty/serial/earlycon.c >> +++ b/drivers/tty/serial/earlycon.c >> @@ -20,6 +20,10 @@ >> #include >> #include >> >> +#ifdef CONFIG_OF_EARLY_FLATTREE >> +#include >> +#endif > > I think you don't need the ifdef around this. > >> + >> #ifdef CONFIG_FIX_EARLYCON_MEM >> #include >> #endif Ok, will take care of that.