All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 07/16] drm: omapdrm: gem: Remove omap_drm_private has_dmm field
Date: Wed, 13 Jan 2016 19:13:21 +0200	[thread overview]
Message-ID: <569685B1.2030606@ti.com> (raw)
In-Reply-To: <1450125584-31701-8-git-send-email-laurent.pinchart@ideasonboard.com>


[-- Attachment #1.1: Type: text/plain, Size: 889 bytes --]


On 14/12/15 22:39, Laurent Pinchart wrote:
> The field is set to true iff the usergart field is not NULL. Test
> usergart instead.

That's true, but I don't like the change.

'has_dmm' means we have DMM (well, TILER, really). TILER is used for 1D
and 2D modes. 'usergart' is only for TILER 2D CPU access (if I'm not
mistaken).

I'm not sure what it would buy us or if it's worth the effort, but maybe
we want to make the 2D mode optional in the future.

And even if we do have 2D mode enabled, due to HW issues a 2D mapped
buffer can't really be accessed by the CPU, as it's just too slow. So
maybe we can have 2D mode supported, but without usergart.

I don't know. But I want to keep these things separated.

That said, maybe some of the 'if's would be cleaner if they checked for
usergart instead of has_dmm, if usergart is really what they depend on.

 Tomi


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-01-13 17:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14 20:39 [PATCH v2 00/16] omapdrm: Implement dma_buf import Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 01/16] drm: omapdrm: Fix plane state free in plane reset handler Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 02/16] drm: omapdrm: Make fbdev emulation optional Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 03/16] drm: omapdrm: gem: Remove unused function prototypes Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 04/16] drm: omapdrm: gem: Remove forward declarations Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 05/16] drm: omapdrm: gem: Group functions by purpose Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 06/16] drm: omapdrm: gem: Move global usergart variable to omap_drm_private Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 07/16] drm: omapdrm: gem: Remove omap_drm_private has_dmm field Laurent Pinchart
2016-01-13 17:13   ` Tomi Valkeinen [this message]
2015-12-14 20:39 ` [PATCH v2 08/16] drm: omapdrm: gem: Mask out private flags passed from userspace Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 09/16] drm: omapdrm: gem: Clean up GEM objects memory flags Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 10/16] drm: omapdrm: gem: Free the correct memory object Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 11/16] drm: omapdrm: gem: Fix GEM object destroy in error path Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 12/16] drm: omapdrm: gem: Don't free mmap offset twice Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 13/16] drm: omapdrm: gem: Simplify error handling when creating GEM object Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 14/16] drm: omapdrm: gem: Remove check for impossible condition Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 15/16] drm: omapdrm: gem: Refactor GEM object allocation Laurent Pinchart
2015-12-14 20:39 ` [PATCH v2 16/16] drm: omapdrm: gem: Implement dma_buf import Laurent Pinchart
2015-12-16 16:18 ` [PATCH v2 00/16] omapdrm: " Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569685B1.2030606@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.