From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 07/16] drm: omapdrm: gem: Remove omap_drm_private has_dmm field Date: Wed, 13 Jan 2016 19:13:21 +0200 Message-ID: <569685B1.2030606@ti.com> References: <1450125584-31701-1-git-send-email-laurent.pinchart@ideasonboard.com> <1450125584-31701-8-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1682732116==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D3256E7CD for ; Wed, 13 Jan 2016 09:13:28 -0800 (PST) In-Reply-To: <1450125584-31701-8-git-send-email-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1682732116== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fwq0s2kH7WT8fK1UnJ0GSSPi7WQxjNuVb" --fwq0s2kH7WT8fK1UnJ0GSSPi7WQxjNuVb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 14/12/15 22:39, Laurent Pinchart wrote: > The field is set to true iff the usergart field is not NULL. Test > usergart instead. That's true, but I don't like the change. 'has_dmm' means we have DMM (well, TILER, really). TILER is used for 1D and 2D modes. 'usergart' is only for TILER 2D CPU access (if I'm not mistaken). I'm not sure what it would buy us or if it's worth the effort, but maybe we want to make the 2D mode optional in the future. And even if we do have 2D mode enabled, due to HW issues a 2D mapped buffer can't really be accessed by the CPU, as it's just too slow. So maybe we can have 2D mode supported, but without usergart. I don't know. But I want to keep these things separated. That said, maybe some of the 'if's would be cleaner if they checked for usergart instead of has_dmm, if usergart is really what they depend on. Tomi --fwq0s2kH7WT8fK1UnJ0GSSPi7WQxjNuVb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWloWxAAoJEPo9qoy8lh71pVoP/jGi5TbsQlKGUa5F3AC1opiU lWQgbrccxzReKy5tzI9ZkFdqkLHDcJEuAftS55GYXvCQDA/xBZ0JDeAf9oyB6X0i XNHbIRJvkZDxOJZJI/cP3NJDEqUT8AmbhvtTcmSGt7Wzng8TGysuCFfF4EiK8oYn 4gGOUysG7nbl9bf4jilpo7PPImplfhH2yiZQGW4OlabTy+pcYKPgSZ7HLkq/hWSo w/tDJ7i4PJTbhS4sCUZrcxai/gIKz7M1OOTO3dU/7yVluVAOAbybCVVUri3dEdoW f1ni+iJHiGknedwGUYuUvfzJhOYYJJndB5xLESlR5XXeURCuKMR2tPemzLSwoB5w tfVA0cvJHCTe0MEUFoepayQNI0f709Z7cAzN+Iy2VX7vMFfYRXz4k6FUdy1GOxUc iV+e9jSp/pqMgtrDZScKsLnJsupoBll8FvE4+X9ZC+DEtlLLl+57l8QSdLjqw8SO LpgziJuta3W6xVVM3WIm/vyNViAkxEEzNDsACZFo1IPgKxilzDn5fBfQ+bYt0uv9 dRtuMa74PtU15HUUd5NTDh5vzWjB90pkWIb+/STOT7Yp1GqkBJ8e1cTAceGGLNG9 R+BkP3PwP80akwOOr99vuAV+4gg7l0deM79UDZmku32r737onKRQ0ZWFr0WH8Ojy c5pMOftQlz4sSG3+1KJO =CiGZ -----END PGP SIGNATURE----- --fwq0s2kH7WT8fK1UnJ0GSSPi7WQxjNuVb-- --===============1682732116== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1682732116==--