diff for duplicates of <5696BFAD.9030905@users.sourceforge.net> diff --git a/a/1.txt b/N1/1.txt index 319412b..32fb725 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,15 +2,15 @@ Hello, The Coccinelle semantic patch "deref_null.cocci" pointed out a potential problem in the implementation of the function "dtsec_config" (lines 1434-1439): -https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/freescale/fman/fman_dtsec.c?idåa03bfd873c29eb786655ef2e95e53ed242b404#n1434 -… +https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/freescale/fman/fman_dtsec.c?id=e5a03bfd873c29eb786655ef2e95e53ed242b404#n1434 +… dtsec->tbiphy = of_phy_find_device(params->internal_phy_node); if (!dtsec->tbiphy) { pr_err("of_phy_find_device (TBI PHY) failed\n"); put_device(&dtsec->tbiphy->mdio.dev); goto err_dtsec_drv_param; } -… +… If the pointer "dtsec->tbiphy" is NULL, then it will especially matter if the shown address computation will succeed. @@ -19,7 +19,3 @@ or was another argument intended? Regards, Markus --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 161f16a..402a77d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0SF Markus Elfring <elfring@users.sourceforge.net>\0" "Subject\0fsl/fman: Clarification for implementation details in dtsec_config()\0" - "Date\0Wed, 13 Jan 2016 21:20:45 +0000\0" + "Date\0Wed, 13 Jan 2016 22:20:45 +0100\0" "To\0netdev@vger.kernel.org" Andrew Lunn <andrew@lunn.ch> Dan Carpenter <dan.carpenter@oracle.com> @@ -15,15 +15,15 @@ "\n" "The Coccinelle semantic patch \"deref_null.cocci\" pointed out a potential\n" "problem in the implementation of the function \"dtsec_config\" (lines 1434-1439):\n" - "https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/freescale/fman/fman_dtsec.c?id\303\245a03bfd873c29eb786655ef2e95e53ed242b404#n1434\n" - "\303\242\342\202\254\302\246\n" + "https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/freescale/fman/fman_dtsec.c?id=e5a03bfd873c29eb786655ef2e95e53ed242b404#n1434\n" + "\342\200\246\n" "\tdtsec->tbiphy = of_phy_find_device(params->internal_phy_node);\n" "\tif (!dtsec->tbiphy) {\n" "\t\tpr_err(\"of_phy_find_device (TBI PHY) failed\\n\");\n" "\t\tput_device(&dtsec->tbiphy->mdio.dev);\n" "\t\tgoto err_dtsec_drv_param;\n" "\t}\n" - "\303\242\342\202\254\302\246\n" + "\342\200\246\n" "\n" "If the pointer \"dtsec->tbiphy\" is NULL, then it will especially matter\n" "if the shown address computation will succeed.\n" @@ -31,10 +31,6 @@ "or was another argument intended?\n" "\n" "Regards,\n" - "Markus\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Markus -68a1bea0fc97835b33999bde1040fd80dbba609648e4d94a3a4d04daad44c4b0 +f1f89d7a5ae7fa3f1864a44137d07ce9e51df795f8df9836736b76e01efb35b2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.