From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755767AbcANCLO (ORCPT ); Wed, 13 Jan 2016 21:11:14 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:38128 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbcANCLM (ORCPT ); Wed, 13 Jan 2016 21:11:12 -0500 Message-ID: <569703B2.1030808@huawei.com> Date: Thu, 14 Jan 2016 10:10:58 +0800 From: Weidong Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Eric Dumazet CC: David Miller , , , , Joe Perches , , , , Paolo Abeni Subject: Re: [PATCH net-next v2] bgmac: fix a missing check for build_skb References: <5695BF41.2040002@huawei.com> <56963AA3.2010804@huawei.com> <1452696749.1223.60.camel@edumazet-glaptop2.roam.corp.google.com> In-Reply-To: <1452696749.1223.60.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.21.100] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.569703BB.00C3,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 27eafd5c8746cf40299ef0550496b13c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/13 22:52, Eric Dumazet wrote: > On Wed, 2016-01-13 at 19:53 +0800, Weidong Wang wrote: >> when build_skb failed, it may occur a NULL pointer. >> So add a 'NULL check' for it. >> >> Signed-off-by: Weidong Wang >> --- >> change log: >> v2: >> fix the error logic change which pointed by Paolo Abni >> and Felix. > > This is too late, you have to send a relative patch, since the prior one > was merged. > > OK. Regards, Weidong > >